media: rzg2l-cru: Mark sink and source pad with MUST_CONNECT flag
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Fri, 18 Oct 2024 13:34:25 +0000 (14:34 +0100)
committerHans Verkuil <hverkuil@xs4all.nl>
Tue, 22 Oct 2024 09:31:26 +0000 (11:31 +0200)
Mark the sink and source pad with the MEDIA_PAD_FL_MUST_CONNECT flag to
ensure pipeline validation fails if it is not connected.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Link: https://lore.kernel.org/r/20241018133446.223516-3-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c
drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c

index 922aa2c58d461be4046e840c74a29980e6f6b62c..43da91c4fdc3e74f6d430c88b93022479dd6a773 100644 (file)
@@ -209,7 +209,7 @@ static int rzg2l_cru_media_init(struct rzg2l_cru_dev *cru)
        const struct of_device_id *match;
        int ret;
 
-       cru->pad.flags = MEDIA_PAD_FL_SINK;
+       cru->pad.flags = MEDIA_PAD_FL_SINK | MEDIA_PAD_FL_MUST_CONNECT;
        ret = media_entity_pads_init(&cru->vdev.entity, 1, &cru->pad);
        if (ret)
                return ret;
index 9f0ea1de50da217c07d7e03ea0dc6eb0be4cde1e..700d8b7046898a4f6246cae46a28a746c67c728b 100644 (file)
@@ -217,8 +217,10 @@ int rzg2l_cru_ip_subdev_register(struct rzg2l_cru_dev *cru)
        ip->subdev.entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER;
        ip->subdev.entity.ops = &rzg2l_cru_ip_entity_ops;
 
-       ip->pads[RZG2L_CRU_IP_SINK].flags = MEDIA_PAD_FL_SINK;
-       ip->pads[RZG2L_CRU_IP_SOURCE].flags = MEDIA_PAD_FL_SOURCE;
+       ip->pads[RZG2L_CRU_IP_SINK].flags = MEDIA_PAD_FL_SINK |
+                                           MEDIA_PAD_FL_MUST_CONNECT;
+       ip->pads[RZG2L_CRU_IP_SOURCE].flags = MEDIA_PAD_FL_SOURCE |
+                                             MEDIA_PAD_FL_MUST_CONNECT;
 
        ret = media_entity_pads_init(&ip->subdev.entity, 2, ip->pads);
        if (ret)