media: video-mux: Add missing media_entity_cleanup upon async register fail
authorAlexander Stein <alexander.stein@ew.tq-group.com>
Tue, 2 May 2023 14:15:43 +0000 (16:15 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 25 May 2023 14:21:22 +0000 (16:21 +0200)
Although media_entity_pads_init has been called, a call to
media_entity_cleanup in the cleanup code was missing.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/video-mux.c

index 1d9f32e5a91716a10bbbd470e9d49e0608f89c18..b244873d593a9ec97bd868a654785ca79ef167ed 100644 (file)
@@ -474,6 +474,7 @@ static int video_mux_probe(struct platform_device *pdev)
 
        ret = video_mux_async_register(vmux, num_pads - 1);
        if (ret) {
+               media_entity_cleanup(&vmux->subdev.entity);
                v4l2_async_nf_unregister(&vmux->notifier);
                v4l2_async_nf_cleanup(&vmux->notifier);
        }