kconfig: qconf: use preferred form of QString API

A QString constructed from a character literal of length 0, i.e. "", is not
"null" for historical reasons. This does not matter here so use the preferred
method isEmpty() instead.

Also directly construct empty QString objects instead of passing in an empty
character literal that has to be parsed into an empty object first.

Signed-off-by: Rolf Eike Beer <eb@emlix.com>
Link: https://doc.qt.io/qt-6/qstring.html#distinction-between-null-and-empty-strings
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index 6c92ef1e16efb175324c554c56dcebdfb74e9036..eaa465b0ccf9c480544ddd7609c3fc4de3a72e13 100644 (file)
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -1464,8 +1464,8 @@ void ConfigMainWindow::loadConfig(void)
 {
        QString str;
 
-       str = QFileDialog::getOpenFileName(this, "", configname);
-       if (str.isNull())
+       str = QFileDialog::getOpenFileName(this, QString(), configname);
+       if (str.isEmpty())
                return;
 
        if (conf_read(str.toLocal8Bit().constData()))
@@ -1491,8 +1491,8 @@ void ConfigMainWindow::saveConfigAs(void)
 {
        QString str;
 
-       str = QFileDialog::getSaveFileName(this, "", configname);
-       if (str.isNull())
+       str = QFileDialog::getSaveFileName(this, QString(), configname);
+       if (str.isEmpty())
                return;
 
        if (conf_write(str.toLocal8Bit().constData())) {