PCI: endpoint: Fix missing destroy_workqueue()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 31 Mar 2021 08:40:12 +0000 (16:40 +0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Tue, 13 Apr 2021 10:43:49 +0000 (11:43 +0100)
Add the missing destroy_workqueue() before return from
pci_epf_test_init() in the error handling case and add
destroy_workqueue() in pci_epf_test_exit().

Link: https://lore.kernel.org/r/20210331084012.2091010-1-yangyingliang@huawei.com
Fixes: 349e7a85b25fa ("PCI: endpoint: functions: Add an EP function to test PCI")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
drivers/pci/endpoint/functions/pci-epf-test.c

index bc35b3566be61b6587e376df8469250661cba116..f9760e73d568c422f9366fd9b759bd007c1c8001 100644 (file)
@@ -925,6 +925,7 @@ static int __init pci_epf_test_init(void)
 
        ret = pci_epf_register_driver(&test_driver);
        if (ret) {
+               destroy_workqueue(kpcitest_workqueue);
                pr_err("Failed to register pci epf test driver --> %d\n", ret);
                return ret;
        }
@@ -935,6 +936,8 @@ module_init(pci_epf_test_init);
 
 static void __exit pci_epf_test_exit(void)
 {
+       if (kpcitest_workqueue)
+               destroy_workqueue(kpcitest_workqueue);
        pci_epf_unregister_driver(&test_driver);
 }
 module_exit(pci_epf_test_exit);