media: atomisp: remove redundant NULL check
authorYang Li <abaci-bugfix@linux.alibaba.com>
Thu, 21 Jan 2021 09:11:52 +0000 (10:11 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 23 Mar 2021 07:52:51 +0000 (08:52 +0100)
Fix below warnings reported by coccicheck:
./drivers/staging/media/atomisp/pci/atomisp_cmd.c:4269:2-8: WARNING:
NULL check before some freeing functions is not needed.
./drivers/staging/media/atomisp/pci/atomisp_cmd.c:4626:2-8: WARNING:
NULL check before some freeing functions is not needed.

Link: https://lore.kernel.org/linux-media/1611220312-89384-3-git-send-email-abaci-bugfix@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_cmd.c

index 6faac81283fe1c0580ae2d9735b89d30efde47a7..cc6b3ce05feda368edf0dd10098eebc3ad10aff5 100644 (file)
@@ -4265,8 +4265,7 @@ int atomisp_set_parameters(struct video_device *vdev,
 apply_parameter_failed:
        if (css_param)
                atomisp_free_css_parameters(css_param);
-       if (param)
-               kvfree(param);
+       kvfree(param);
 
        return ret;
 }
@@ -4626,8 +4625,7 @@ atomisp_v4l2_framebuffer_to_css_frame(const struct v4l2_framebuffer *arg,
 err:
        if (ret && res)
                ia_css_frame_free(res);
-       if (tmp_buf)
-               vfree(tmp_buf);
+       vfree(tmp_buf);
        if (ret == 0)
                *result = res;
        return ret;