wifi: iwlwifi: mvm: update IGTK in mvmvif upon D3 resume
authorYedidya Benshimol <yedidya.ben.shimol@intel.com>
Tue, 17 Oct 2023 09:16:48 +0000 (12:16 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 23 Oct 2023 10:48:30 +0000 (12:48 +0200)
During the D3 resume flow, all new rekeys are passed from the FW.
Because the FW supports only one IGTK at a time, every IGTK rekey
update should be done by removing the last IGTK. The mvmvif holds a
pointer to the last IGTK for that reason and thus should be updated
when a new IGTK is passed upon resume.

Fixes: 04f78e242fff ("wifi: iwlwifi: mvm: Add support for IGTK in D3 resume flow")
Signed-off-by: Yedidya Benshimol <yedidya.ben.shimol@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20231017115047.8ceaf7e5ece7.Ief444f6a2703ed76648b4d414f12bb4130bab36e@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/d3.c

index ffb1fdd7ee325e554e1c9b09b91aa1bfa0d61aa1..46ee280231eae93a32a5890b6e2f60bdaff1147a 100644 (file)
@@ -2031,6 +2031,16 @@ iwl_mvm_d3_igtk_bigtk_rekey_add(struct iwl_wowlan_status_data *status,
        if (IS_ERR(key_config))
                return false;
        ieee80211_set_key_rx_seq(key_config, 0, &seq);
+
+       if (key_config->keyidx == 4 || key_config->keyidx == 5) {
+               struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
+               int link_id = vif->active_links ? __ffs(vif->active_links) : 0;
+               struct iwl_mvm_vif_link_info *mvm_link =
+                       mvmvif->link[link_id];
+
+               mvm_link->igtk = key_config;
+       }
+
        return true;
 }