media: Staging: media: atomisp: Use kcalloc instead of kzalloc
authorSrishti Sharma <srishtishar@gmail.com>
Thu, 14 Sep 2017 10:18:40 +0000 (06:18 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sat, 23 Sep 2017 19:09:01 +0000 (15:09 -0400)
Use kcalloc instead of kzalloc to check for an overflow before
multiplication. Done using the following semantic patch by
coccinelle.

http://coccinelle.lip6.fr/rules/kzalloc.cocci

Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c

index 696f5020dce65b6fba02954f539397019739dcd2..5e45d5fe0b2a73070c17c4b024b05e0cb8bf35f1 100644 (file)
@@ -235,7 +235,9 @@ sh_css_load_firmware(const char *fw_data,
                sh_css_blob_info = NULL;
        }
 
-       fw_minibuffer = kzalloc(sh_css_num_binaries * sizeof(struct fw_param), GFP_KERNEL);
+       fw_minibuffer = kcalloc(sh_css_num_binaries, sizeof(struct fw_param),
+                               GFP_KERNEL);
+
        if (fw_minibuffer == NULL)
                return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;