selftests/proc: fix string literal warning in proc-maps-race.c
authorSukrut Heroorkar <hsukrut3@gmail.com>
Mon, 4 Aug 2025 22:56:14 +0000 (00:56 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 12 Aug 2025 06:00:59 +0000 (23:00 -0700)
This change resolves non literal string format warning invoked for
proc-maps-race.c while compiling.

proc-maps-race.c:205:17: warning: format not a string literal and no format arguments [-Wformat-security]
 205 |                 printf(text);
     |                 ^~~~~~
proc-maps-race.c:209:17: warning: format not a string literal and no format arguments [-Wformat-security]
 209 |                 printf(text);
     |                 ^~~~~~
proc-maps-race.c: In function `print_last_lines':
proc-maps-race.c:224:9: warning: format not a string literal and no format arguments [-Wformat-security]
 224 |         printf(start);
     |         ^~~~~~

Add string format specifier %s for the printf calls in both
print_first_lines() and print_last_lines() thus resolving the warnings.

The test executes fine after this change thus causing no effect to the
functional behavior of the test.

Link: https://lkml.kernel.org/r/20250804225633.841777-1-hsukrut3@gmail.com
Fixes: aadc099c480f ("selftests/proc: add verbose mode for /proc/pid/maps tearing tests")
Signed-off-by: Sukrut Heroorkar <hsukrut3@gmail.com>
Acked-by: Suren Baghdasaryan <surenb@google.com>
Cc: David Hunter <david.hunter.linux@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/testing/selftests/proc/proc-maps-race.c

index 66773685a047b6ce9e8e75c2f16282c51c12a219..94bba45531300172a99049fc9b7854c51036440a 100644 (file)
@@ -202,11 +202,11 @@ static void print_first_lines(char *text, int nr)
                int offs = end - text;
 
                text[offs] = '\0';
-               printf(text);
+               printf("%s", text);
                text[offs] = '\n';
                printf("\n");
        } else {
-               printf(text);
+               printf("%s", text);
        }
 }
 
@@ -221,7 +221,7 @@ static void print_last_lines(char *text, int nr)
                nr--;
                start--;
        }
-       printf(start);
+       printf("%s", start);
 }
 
 static void print_boundaries(const char *title, FIXTURE_DATA(proc_maps_race) *self)