projects
/
fio.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c656b90
)
backend: fix the memory leak if fio_memalign fails,
author
Ziye Yang
<ziye.yang@intel.com>
Tue, 29 Oct 2019 14:35:38 +0000
(22:35 +0800)
committer
Ziye Yang
<ziye.yang@intel.com>
Tue, 29 Oct 2019 14:37:38 +0000
(22:37 +0800)
We should not use break, we should use return 1 and explictly fails this,
then the cleanup routine will work. If not, this function may still
return 0.
Signed-off-by: Gang Cao <cao.gang@intel.com>
Signed-off-by: Ziye Yang <ziye.yang@intel.com>
backend.c
patch
|
blob
|
blame
|
history
diff --git
a/backend.c
b/backend.c
index fe868271a6cd90e755743965bdaf0936826272c1..cb15b0e626ea1264f39f16532dfde454706248eb 100644
(file)
--- a/
backend.c
+++ b/
backend.c
@@
-1236,7
+1236,7
@@
static int init_io_u(struct thread_data *td)
ptr = fio_memalign(cl_align, sizeof(*io_u), td_offload_overlap(td));
if (!ptr) {
log_err("fio: unable to allocate aligned memory\n");
-
break
;
+
return 1
;
}
io_u = ptr;