ACPI: platform_profile: Move matching string for new profile out of mutex
authorMario Limonciello <mario.limonciello@amd.com>
Fri, 6 Dec 2024 03:19:03 +0000 (21:19 -0600)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 10 Dec 2024 17:17:56 +0000 (19:17 +0200)
Holding the mutex is not necessary while scanning the string passed into
platform_profile_store().

Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20241206031918.1537-8-mario.limonciello@amd.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/acpi/platform_profile.c

index 4f5623fc27c0981aa891ecf3c53db5f47758432f..45ffd85a71dd5be005c3ede33fc55abd133700af 100644 (file)
@@ -83,6 +83,11 @@ static ssize_t platform_profile_store(struct device *dev,
 {
        int err, i;
 
+       /* Scan for a matching profile */
+       i = sysfs_match_string(profile_names, buf);
+       if (i < 0)
+               return -EINVAL;
+
        err = mutex_lock_interruptible(&profile_lock);
        if (err)
                return err;
@@ -92,13 +97,6 @@ static ssize_t platform_profile_store(struct device *dev,
                return -ENODEV;
        }
 
-       /* Scan for a matching profile */
-       i = sysfs_match_string(profile_names, buf);
-       if (i < 0) {
-               mutex_unlock(&profile_lock);
-               return -EINVAL;
-       }
-
        /* Check that platform supports this profile choice */
        if (!test_bit(i, cur_profile->choices)) {
                mutex_unlock(&profile_lock);