octeontx2-af: convert dev_dbg to tracepoint in mbox
authorSubbaraya Sundeep <sbhatta@marvell.com>
Tue, 13 May 2025 11:40:05 +0000 (17:10 +0530)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 15 May 2025 11:25:16 +0000 (13:25 +0200)
Use tracepoint instead of dev_dbg since the entire
mailbox code uses tracepoints for debugging.

Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Link: https://patch.msgid.link/1747136408-30685-2-git-send-email-sbhatta@marvell.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/marvell/octeontx2/af/mbox.c
drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.h

index 1e5aa539750404e14ba40c7581218a2541efce00..5547d20310df3f4678d1b5d08ccc74ad9f240e17 100644 (file)
@@ -188,14 +188,13 @@ int otx2_mbox_wait_for_rsp(struct otx2_mbox *mbox, int devid)
 {
        unsigned long timeout = jiffies + msecs_to_jiffies(MBOX_RSP_TIMEOUT);
        struct otx2_mbox_dev *mdev = &mbox->dev[devid];
-       struct device *sender = &mbox->pdev->dev;
 
        while (!time_after(jiffies, timeout)) {
                if (mdev->num_msgs == mdev->msgs_acked)
                        return 0;
                usleep_range(800, 1000);
        }
-       dev_dbg(sender, "timed out while waiting for rsp\n");
+       trace_otx2_msg_wait_rsp(mbox->pdev);
        return -EIO;
 }
 EXPORT_SYMBOL(otx2_mbox_wait_for_rsp);
index 5704520f9b0258255222604afcb053ea0c4fb054..6b5a14dcb6436e25a424915ae19dc786815d318d 100644 (file)
@@ -95,6 +95,17 @@ TRACE_EVENT(otx2_msg_process,
                      otx2_mbox_id2name(__entry->id), __entry->err)
 );
 
+TRACE_EVENT(otx2_msg_wait_rsp,
+           TP_PROTO(const struct pci_dev *pdev),
+           TP_ARGS(pdev),
+           TP_STRUCT__entry(__string(dev, pci_name(pdev))
+           ),
+           TP_fast_assign(__assign_str(dev)
+           ),
+           TP_printk("[%s] timed out while waiting for response\n",
+                     __get_str(dev))
+);
+
 #endif /* __RVU_TRACE_H */
 
 #undef TRACE_INCLUDE_PATH