dmaengine: k3dma: remove useless ON_WARN_ONCE()
authorAntonio Borneo <borneo.antonio@gmail.com>
Tue, 1 Aug 2017 20:09:27 +0000 (22:09 +0200)
committerVinod Koul <vinod.koul@intel.com>
Fri, 25 Aug 2017 06:45:40 +0000 (12:15 +0530)
Commit 36387a2b1f62b5c087c5fe6f0f7b23b94f722ad7 ("k3dma: Fix
memory handling in preparation for cyclic mode") adds few
calls to ON_WARN_ONCE() to track the use of ds_run/ds_done.

After the two fixes:
- dmaengine: k3dma: fix non-cyclic mode
- dmaengine: k3dma: fix re-free of the same descriptor
the behaviour of ds_run/ds_done is properly fixed.
The remaining ON_WARN_ONCE() are never triggered and can be
removed.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/k3dma.c

index b7696236351960ef2549032a17dcd7068b1ad714..01d2a750a6217c062daedbac6b44d0e59aafd2e2 100644 (file)
@@ -223,7 +223,6 @@ static irqreturn_t k3_dma_int_handler(int irq, void *dev_id)
                        if (c && (tc1 & BIT(i))) {
                                spin_lock_irqsave(&c->vc.lock, flags);
                                vchan_cookie_complete(&p->ds_run->vd);
-                               WARN_ON_ONCE(p->ds_done);
                                p->ds_done = p->ds_run;
                                p->ds_run = NULL;
                                spin_unlock_irqrestore(&c->vc.lock, flags);
@@ -274,7 +273,6 @@ static int k3_dma_start_txd(struct k3_dma_chan *c)
                 */
                list_del(&ds->vd.node);
 
-               WARN_ON_ONCE(c->phy->ds_run);
                c->phy->ds_run = ds;
                c->phy->ds_done = NULL;
                /* start dma */