ASoC: cs35l56: Remove duplicate mbox log messages
authorSimon Trimmer <simont@opensource.cirrus.com>
Thu, 20 Apr 2023 10:20:43 +0000 (11:20 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 20 Apr 2023 11:52:04 +0000 (12:52 +0100)
cs35l56_mbox_send() logs a warning when sending a mbox command fails so
the callers can be simplified.

Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230420102043.1151830-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l56.c

index c0a857cfb8cbdcb3350f27acacc27673de80fcb8..46762f7f1449f2d452effaa8267db03b93ed1de5 100644 (file)
@@ -859,10 +859,8 @@ static void cs35l56_dsp_work(struct work_struct *work)
        }
 
        ret = cs35l56_mbox_send(cs35l56, CS35L56_MBOX_CMD_SHUTDOWN);
-       if (ret) {
-               dev_dbg(cs35l56->dev, "%s: CS35L56_MBOX_CMD_SHUTDOWN ret %d\n", __func__, ret);
+       if (ret)
                goto err;
-       }
 
        if (cs35l56->rev < CS35L56_REVID_B0)
                reg = CS35L56_DSP1_PM_CUR_STATE_A1;
@@ -1033,9 +1031,7 @@ int cs35l56_runtime_suspend(struct device *dev)
         * Enable auto-hibernate. If it is woken by some other wake source
         * it will automatically return to hibernate.
         */
-       ret = cs35l56_mbox_send(cs35l56, CS35L56_MBOX_CMD_ALLOW_AUTO_HIBERNATE);
-       if (ret)
-               dev_warn(cs35l56->dev, "ALLOW_HIBERNATE failed: %d\n", ret);
+       cs35l56_mbox_send(cs35l56, CS35L56_MBOX_CMD_ALLOW_AUTO_HIBERNATE);
 
        /*
         * Must enter cache-only first so there can't be any more register