x86/boot: Disable stack protector for early boot code
authorBrian Gerst <brgerst@gmail.com>
Thu, 23 Jan 2025 19:07:35 +0000 (14:07 -0500)
committerIngo Molnar <mingo@kernel.org>
Tue, 18 Feb 2025 09:14:51 +0000 (10:14 +0100)
On 64-bit, this will prevent crashes when the canary access is changed
from %gs:40 to %gs:__stack_chk_guard(%rip).  RIP-relative addresses from
the identity-mapped early boot code will target the wrong address with
zero-based percpu.  KASLR could then shift that address to an unmapped
page causing a crash on boot.

This early boot code runs well before user-space is active and does not
need stack protector enabled.

Signed-off-by: Brian Gerst <brgerst@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/20250123190747.745588-4-brgerst@gmail.com
arch/x86/kernel/Makefile

index b43eb7e384eba204f190ba384da79cbd1a3a21de..84cfa179802c3901922d578aaca2fbd0bffe0a90 100644 (file)
@@ -44,6 +44,8 @@ KCOV_INSTRUMENT_unwind_orc.o                          := n
 KCOV_INSTRUMENT_unwind_frame.o                         := n
 KCOV_INSTRUMENT_unwind_guess.o                         := n
 
+CFLAGS_head32.o := -fno-stack-protector
+CFLAGS_head64.o := -fno-stack-protector
 CFLAGS_irq.o := -I $(src)/../include/asm/trace
 
 obj-y                  += head_$(BITS).o