bnxt_en: Remove the -1 error return code from bnxt_hwrm_do_send_msg().
authorMichael Chan <michael.chan@broadcom.com>
Fri, 30 Aug 2019 03:54:45 +0000 (23:54 -0400)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Aug 2019 21:02:18 +0000 (14:02 -0700)
Replace the non-standard -1 code with -EBUSY when there is no firmware
response after waiting for the maximum timeout.

Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index b9ad43d3dc51c560bba06a04e5092f4811b8e825..c8550ca734548358d98f76645e1b03a1b5a712c7 100644 (file)
@@ -4162,7 +4162,7 @@ static int bnxt_hwrm_do_send_msg(struct bnxt *bp, void *msg, u32 msg_len,
                if (bp->hwrm_intr_seq_id != (u16)~seq_id) {
                        netdev_err(bp->dev, "Resp cmpl intr err msg: 0x%x\n",
                                   le16_to_cpu(req->req_type));
-                       return -1;
+                       return -EBUSY;
                }
                len = (le32_to_cpu(*resp_len) & HWRM_RESP_LEN_MASK) >>
                      HWRM_RESP_LEN_SFT;
@@ -4190,7 +4190,7 @@ static int bnxt_hwrm_do_send_msg(struct bnxt *bp, void *msg, u32 msg_len,
                                   HWRM_TOTAL_TIMEOUT(i),
                                   le16_to_cpu(req->req_type),
                                   le16_to_cpu(req->seq_id), len);
-                       return -1;
+                       return -EBUSY;
                }
 
                /* Last byte of resp contains valid bit */
@@ -4208,7 +4208,7 @@ static int bnxt_hwrm_do_send_msg(struct bnxt *bp, void *msg, u32 msg_len,
                                   HWRM_TOTAL_TIMEOUT(i),
                                   le16_to_cpu(req->req_type),
                                   le16_to_cpu(req->seq_id), len, *valid);
-                       return -1;
+                       return -EBUSY;
                }
        }