xfs: fix check on struct_version for versions 4 or greater
authorColin Ian King <colin.king@canonical.com>
Fri, 12 Jan 2018 16:47:50 +0000 (08:47 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 12 Jan 2018 22:09:08 +0000 (14:09 -0800)
It appears that the check for versions 4 or more is incorrect and is
off-by-one. Fix this.

Detected by CoverityScan, CID#1463775 ("Logically dead code")

Fixes: ac503a4cc9e8 ("xfs: refactor the geometry structure filling function")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/libxfs/xfs_sb.c

index 35b005d66977f630fb63f57646e38de09470958f..869a2f3f0375291671d108dc41146f7994c23210 100644 (file)
@@ -951,7 +951,7 @@ xfs_fs_geometry(
        geo->rtsectsize = sbp->sb_blocksize;
        geo->dirblocksize = xfs_dir2_dirblock_bytes(sbp);
 
-       if (struct_version < 3)
+       if (struct_version < 4)
                return 0;
 
        if (xfs_sb_version_haslogv2(sbp))