virtgpu: remove redundant task_comm copying
authorMichał Mirosław <mirq-linux@rere.qmqm.pl>
Thu, 31 Aug 2017 18:06:12 +0000 (20:06 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 10 Nov 2017 11:45:35 +0000 (12:45 +0100)
Remove redundant task name copying because:

1. task->comm is already NUL-terminated
2. virtio_gpu_context_create() trims passed dbgname anyway

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Link: http://patchwork.freedesktop.org/patch/msgid/588612bbc672e8b598e10f79fcbc041122e844ba.1504202471.git.mirq-linux@rere.qmqm.pl
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/virtio/virtgpu_kms.c

index 6400506a06b07036d77be04cdb6cb9fe567a7419..65060c08522d79b6df6eaeabe2499d98d67d80c6 100644 (file)
@@ -272,20 +272,18 @@ int virtio_gpu_driver_open(struct drm_device *dev, struct drm_file *file)
        struct virtio_gpu_device *vgdev = dev->dev_private;
        struct virtio_gpu_fpriv *vfpriv;
        uint32_t id;
-       char dbgname[64], tmpname[TASK_COMM_LEN];
+       char dbgname[TASK_COMM_LEN];
 
        /* can't create contexts without 3d renderer */
        if (!vgdev->has_virgl_3d)
                return 0;
 
-       get_task_comm(tmpname, current);
-       snprintf(dbgname, sizeof(dbgname), "%s", tmpname);
-       dbgname[63] = 0;
        /* allocate a virt GPU context for this opener */
        vfpriv = kzalloc(sizeof(*vfpriv), GFP_KERNEL);
        if (!vfpriv)
                return -ENOMEM;
 
+       get_task_comm(dbgname, current);
        virtio_gpu_context_create(vgdev, strlen(dbgname), dbgname, &id);
 
        vfpriv->ctx_id = id;