scsi: ufs: core: Fix WB resize using wrong offset
authorHuan Tang <tanghuan@vivo.com>
Wed, 23 Apr 2025 09:29:17 +0000 (17:29 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 29 Apr 2025 01:18:57 +0000 (21:18 -0400)
Commit 500d4b742e0c ("scsi: ufs: core: Add WB buffer resize support")
incorrectly reads the value of offset
DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP to determine whether WB resize is
supported.

Fix the issue by reading the value of DEVICE_DESC_PARAM_EXT_WB_SUP to
determine whether the device supports WB resize.

Fixes: 500d4b742e0c ("scsi: ufs: core: Add WB buffer resize support")
Reported-by: Peter Wang <peter.wang@mediatek.com>
Closes: https://lore.kernel.org/all/7ce05b28f5d4b4b4973244310010c1487
Signed-off-by: Huan Tang <tanghuan@vivo.com>
Link: https://lore.kernel.org/r/20250423092917.1031-1-tanghuan@vivo.com
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c

index dc55c94fa45e592d815e6177b0a09390b2bcef97..1c53ccf5a616c096af7b69c81b40fc4ac25d12f0 100644 (file)
@@ -8143,7 +8143,7 @@ static void ufshcd_wb_probe(struct ufs_hba *hba, const u8 *desc_buf)
        dev_info->wb_buffer_type = desc_buf[DEVICE_DESC_PARAM_WB_TYPE];
 
        dev_info->ext_wb_sup =  get_unaligned_be16(desc_buf +
-                                               DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP);
+                                               DEVICE_DESC_PARAM_EXT_WB_SUP);
 
        dev_info->b_presrv_uspc_en =
                desc_buf[DEVICE_DESC_PARAM_WB_PRESRV_USRSPC_EN];