irqchip/stm32: Fix non-SMP build warning
authorArnd Bergmann <arnd@arndb.de>
Tue, 5 Jun 2018 11:43:34 +0000 (13:43 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 6 Jun 2018 10:05:19 +0000 (12:05 +0200)
A CONFIG_SMP=n build emits a harmless compile-time warning:

drivers/irqchip/irq-stm32-exti.c:495:12: error: 'stm32_exti_h_set_affinity' defined but not used [-Werror=unused-function]

The #ifdef is inconsistent here, and it's better to use an IS_ENABLED() check
that lets the compiler silently drop that function.

Fixes: 927abfc4461e ("irqchip/stm32: Add stm32mp1 support with hierarchy domain")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Ludovic Barre <ludovic.barre@st.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Link: https://lkml.kernel.org/r/20180605114347.1347128-1-arnd@arndb.de
drivers/irqchip/irq-stm32-exti.c

index 5089c1e2838db6c60feba40c20fc012aee3f0087..3a7e8905a97e93e42fa9b7646a3ada306c18c4be 100644 (file)
@@ -552,9 +552,7 @@ static struct irq_chip stm32_exti_h_chip = {
        .irq_set_type           = stm32_exti_h_set_type,
        .irq_set_wake           = stm32_exti_h_set_wake,
        .flags                  = IRQCHIP_MASK_ON_SUSPEND,
-#ifdef CONFIG_SMP
-       .irq_set_affinity       = stm32_exti_h_set_affinity,
-#endif
+       .irq_set_affinity       = IS_ENABLED(CONFIG_SMP) ? stm32_exti_h_set_affinity : NULL,
 };
 
 static int stm32_exti_h_domain_alloc(struct irq_domain *dm,