habanalabs: silence an uninitialized variable warning
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 11 Jan 2022 07:16:51 +0000 (10:16 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 28 Feb 2022 12:22:04 +0000 (14:22 +0200)
Smatch warns that:

    drivers/misc/habanalabs/common/command_buffer.c:471 hl_cb_ioctl()
    error: uninitialized symbol 'device_va'.

Which is true, but harmless.  Anyway, it's easy to silence this by
adding a error check.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/common/command_buffer.c

index 3c0ae07a2d8038385825037077392c435b1b3ed7..b9483a3cee9183326e134e434ef0468b81634284 100644 (file)
@@ -464,6 +464,8 @@ int hl_cb_ioctl(struct hl_fpriv *hpriv, void *data)
                                args->in.flags,
                                &usage_cnt,
                                &device_va);
+               if (rc)
+                       break;
 
                memset(&args->out, 0, sizeof(args->out));