net: sched: cls_matchall: no need to call tcf_exts_change for newly allocated struct

As the head struct was allocated right before mall_set_parms call,
no need to use tcf_exts_change to do atomic change, and we can just
fill-up the unused exts struct directly by tcf_exts_validate.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c
index 9dc26c32cf321e475a8f783cf423ff67562479fa..f35177b48373b512b9cca9a45847c1e30f27f546 100644 (file)
--- a/net/sched/cls_matchall.c
+++ b/net/sched/cls_matchall.c
@@ -120,27 +120,17 @@ static int mall_set_parms(struct net *net, struct tcf_proto *tp,
                          unsigned long base, struct nlattr **tb,
                          struct nlattr *est, bool ovr)
 {
-       struct tcf_exts e;
        int err;
 
-       err = tcf_exts_init(&e, TCA_MATCHALL_ACT, 0);
-       if (err)
-               return err;
-       err = tcf_exts_validate(net, tp, tb, est, &e, ovr);
+       err = tcf_exts_validate(net, tp, tb, est, &head->exts, ovr);
        if (err < 0)
-               goto errout;
+               return err;
 
        if (tb[TCA_MATCHALL_CLASSID]) {
                head->res.classid = nla_get_u32(tb[TCA_MATCHALL_CLASSID]);
                tcf_bind_filter(tp, &head->res, base);
        }
-
-       tcf_exts_change(tp, &head->exts, &e);
-
        return 0;
-errout:
-       tcf_exts_destroy(&e);
-       return err;
 }
 
 static int mall_change(struct net *net, struct sk_buff *in_skb,