drm/vgem: remove _unlocked suffix in drm_gem_object_put_unlocked
authorEmil Velikov <emil.velikov@collabora.com>
Fri, 15 May 2020 09:51:14 +0000 (10:51 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Tue, 19 May 2020 21:31:36 +0000 (22:31 +0100)
Spelling out _unlocked for each and every driver is a annoying.
Especially if we consider how many drivers, do not know (or need to)
about the horror stories involving struct_mutex.

Just drop the suffix. It makes the API cleaner.

Done via the following script:

__from=drm_gem_object_put_unlocked
__to=drm_gem_object_put
for __file in $(git grep --name-only $__from); do
  sed -i  "s/$__from/$__to/g" $__file;
done

Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Emil Velikov <emil.velikov@collabora.com>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20200515095118.2743122-35-emil.l.velikov@gmail.com
drivers/gpu/drm/vgem/vgem_drv.c
drivers/gpu/drm/vgem/vgem_fence.c

index ec1a8ebb6f1bfcad766f1a0effb2c305f9e11388..e4dc7b267a0b8b1046b57680133f263d488d849b 100644 (file)
@@ -198,7 +198,7 @@ static struct drm_gem_object *vgem_gem_create(struct drm_device *dev,
 
        ret = drm_gem_handle_create(file, &obj->base, handle);
        if (ret) {
-               drm_gem_object_put_unlocked(&obj->base);
+               drm_gem_object_put(&obj->base);
                return ERR_PTR(ret);
        }
 
@@ -223,7 +223,7 @@ static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
        args->size = gem_object->size;
        args->pitch = pitch;
 
-       drm_gem_object_put_unlocked(gem_object);
+       drm_gem_object_put(gem_object);
 
        DRM_DEBUG("Created object of size %llu\n", args->size);
 
@@ -251,7 +251,7 @@ static int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev,
 
        *offset = drm_vma_node_offset_addr(&obj->vma_node);
 unref:
-       drm_gem_object_put_unlocked(obj);
+       drm_gem_object_put(obj);
 
        return ret;
 }
index 9268f6fc3f6622a71e435a143e2d0b6c199b6887..17f32f550dd9965b5c5eaba1d9b56c7b2f9c44de 100644 (file)
@@ -182,7 +182,7 @@ err_fence:
                dma_fence_put(fence);
        }
 err:
-       drm_gem_object_put_unlocked(obj);
+       drm_gem_object_put(obj);
        return ret;
 }