drm/amd/amdgpu: Simplify switch case statements in amdgpu_connectors.c
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Thu, 27 Apr 2023 14:42:31 +0000 (20:12 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Jun 2023 13:25:43 +0000 (09:25 -0400)
Fix the following checkpatch errors:

ERROR: trailing statements should be on next line
ERROR: space required after that ',' (ctx:VxV)
ERROR: code indent should use tabs where possible

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c

index 6be30dcb029d579dd28995c10c0a8a27c762b81f..d34037b85cf8599d166f4981689611a951e8e82a 100644 (file)
@@ -593,11 +593,20 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 
                switch (val) {
                default:
-               case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
-               case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
-               case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
-               case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
+               case DRM_MODE_SCALE_NONE:
+                       rmx_type = RMX_OFF;
+                       break;
+               case DRM_MODE_SCALE_CENTER:
+                       rmx_type = RMX_CENTER;
+                       break;
+               case DRM_MODE_SCALE_ASPECT:
+                       rmx_type = RMX_ASPECT;
+                       break;
+               case DRM_MODE_SCALE_FULLSCREEN:
+                       rmx_type = RMX_FULL;
+                       break;
                }
+
                if (amdgpu_encoder->rmx_type == rmx_type)
                        return 0;
 
@@ -799,12 +808,21 @@ static int amdgpu_connector_set_lcd_property(struct drm_connector *connector,
        }
 
        switch (value) {
-       case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
-       case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
-       case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
+       case DRM_MODE_SCALE_NONE:
+               rmx_type = RMX_OFF;
+               break;
+       case DRM_MODE_SCALE_CENTER:
+               rmx_type = RMX_CENTER;
+               break;
+       case DRM_MODE_SCALE_ASPECT:
+               rmx_type = RMX_ASPECT;
+               break;
        default:
-       case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
+       case DRM_MODE_SCALE_FULLSCREEN:
+               rmx_type = RMX_FULL;
+               break;
        }
+
        if (amdgpu_encoder->rmx_type == rmx_type)
                return 0;
 
@@ -1127,7 +1145,8 @@ amdgpu_connector_dvi_detect(struct drm_connector *connector, bool force)
                                        /* assume digital unless load detected otherwise */
                                        amdgpu_connector->use_digital = true;
                                        lret = encoder_funcs->detect(encoder, connector);
-                                       DRM_DEBUG_KMS("load_detect %x returned: %x\n",encoder->encoder_type,lret);
+                                       DRM_DEBUG_KMS("load_detect %x returned: %x\n",
+                                                     encoder->encoder_type, lret);
                                        if (lret == connector_status_connected)
                                                amdgpu_connector->use_digital = false;
                                }
@@ -1991,7 +2010,7 @@ amdgpu_connector_add(struct amdgpu_device *adev,
        if (amdgpu_connector->hpd.hpd == AMDGPU_HPD_NONE) {
                if (i2c_bus->valid) {
                        connector->polled = DRM_CONNECTOR_POLL_CONNECT |
-                                           DRM_CONNECTOR_POLL_DISCONNECT;
+                                               DRM_CONNECTOR_POLL_DISCONNECT;
                }
        } else
                connector->polled = DRM_CONNECTOR_POLL_HPD;