jfs: fix bogus variable self-initialization
authorArnd Bergmann <arnd@arndb.de>
Fri, 22 Mar 2019 14:19:16 +0000 (15:19 +0100)
committerDave Kleikamp <dave.kleikamp@oracle.com>
Fri, 22 Mar 2019 14:38:37 +0000 (09:38 -0500)
A statement was originally added in 2006 to shut up a gcc warning,
now but now clang warns about it:

fs/jfs/jfs_txnmgr.c:1932:15: error: variable 'pxd' is uninitialized when used within its own initialization
      [-Werror,-Wuninitialized]
                pxd_t pxd = pxd;        /* truncated extent of xad */
                      ~~~   ^~~

Modern versions of gcc are fine without the silly assignment, so just
drop it. Tested with gcc-4.6 (released 2011), 4.7, 4.8, and 4.9.

Fixes: c9e3ad6021e5 ("JFS: Get rid of "may be used uninitialized" warnings")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
fs/jfs/jfs_txnmgr.c

index a5663cb621d8d16cb55968e2c4d8d0b86a7fbe3a..78789c5ed36b02f7106c40630e484656612c891f 100644 (file)
@@ -1928,8 +1928,7 @@ static void xtLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         * header ?
         */
        if (tlck->type & tlckTRUNCATE) {
-               /* This odd declaration suppresses a bogus gcc warning */
-               pxd_t pxd = pxd;        /* truncated extent of xad */
+               pxd_t pxd;      /* truncated extent of xad */
                int twm;
 
                /*