ublk: remove the check of ublk_need_req_ref() from __ublk_check_and_get_req
authorMing Lei <ming.lei@redhat.com>
Tue, 29 Apr 2025 02:29:39 +0000 (10:29 +0800)
committerJens Axboe <axboe@kernel.dk>
Tue, 29 Apr 2025 12:01:36 +0000 (06:01 -0600)
__ublk_check_and_get_req() is only called from ublk_check_and_get_req()
and ublk_register_io_buf(), the same check has been covered in the two
calling sites.

So remove the check from __ublk_check_and_get_req().

Suggested-by: Caleb Sander Mateos <csander@purestorage.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20250429022941.1718671-5-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c

index c624d8f653ae37da706af0e46c5fb59468902cdd..f9032076bc06158f77f5b2d2e2cab2f05ab94efa 100644 (file)
@@ -2148,9 +2148,6 @@ static inline struct request *__ublk_check_and_get_req(struct ublk_device *ub,
 {
        struct request *req;
 
-       if (!ublk_need_req_ref(ubq))
-               return NULL;
-
        req = blk_mq_tag_to_rq(ub->tag_set.tags[ubq->q_id], tag);
        if (!req)
                return NULL;