net: ibm: emac: use devm for register_netdev
authorRosen Penev <rosenp@gmail.com>
Thu, 12 Sep 2024 02:48:59 +0000 (19:48 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 14 Sep 2024 04:48:57 +0000 (21:48 -0700)
Cleans it up automatically. No need to handle manually.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20240912024903.6201-6-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/emac/core.c

index 9596eca20317b2960699faa14837f6ac249ba00f..65e78f9a5038cdd46e0c43077031725d13d14442 100644 (file)
@@ -3182,7 +3182,7 @@ static int emac_probe(struct platform_device *ofdev)
 
        netif_carrier_off(ndev);
 
-       err = register_netdev(ndev);
+       err = devm_register_netdev(&ofdev->dev, ndev);
        if (err) {
                printk(KERN_ERR "%pOF: failed to register net device (%d)!\n",
                       np, err);
@@ -3248,8 +3248,6 @@ static void emac_remove(struct platform_device *ofdev)
 
        DBG(dev, "remove" NL);
 
-       unregister_netdev(dev->ndev);
-
        cancel_work_sync(&dev->reset_work);
 
        if (emac_has_feature(dev, EMAC_FTR_HAS_TAH))