pmdomain: rockchip: add regulator dependency
authorArnd Bergmann <arnd@arndb.de>
Tue, 4 Mar 2025 14:27:59 +0000 (15:27 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 5 Mar 2025 14:46:33 +0000 (15:46 +0100)
When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:

drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration]
  653 |                 pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
      |                              ^~~~~~~~~~~~~~~~~~~~~
      |                              devm_regulator_get
drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  653 |                 pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
      |                            ^

Add a Kconfig dependency.

Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20250304142803.689201-1-arnd@kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/pmdomain/rockchip/Kconfig

index 7e4f9b628f0b78b139e1b96a6e15356a28274985..218d43186e5b9a38362e18f454b913f64229cbd4 100644 (file)
@@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS
        bool "Rockchip generic power domain"
        depends on PM
        depends on HAVE_ARM_SMCCC_DISCOVERY
+       depends on REGULATOR
        select PM_GENERIC_DOMAINS
        help
          Say y here to enable power domain support.