msm/fbdev: fix unused variable warning with clang.
authorDave Airlie <airlied@redhat.com>
Wed, 22 Feb 2023 23:47:29 +0000 (09:47 +1000)
committerDave Airlie <airlied@redhat.com>
Wed, 22 Feb 2023 23:48:05 +0000 (09:48 +1000)
clang builds showed this:
drivers/gpu/drm/msm/msm_fbdev.c:144:6: error: variable 'helper' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
        if (!fbdev)
            ^~~~~~

Fixes: 3fb1f62f80a1 ("drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()")
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/msm/msm_fbdev.c

index c804e5ba682af3ff9afc24de4f775fd8e7ed1042..c1356aff87da3dc64c205681993dfb67a07eeb15 100644 (file)
@@ -142,7 +142,7 @@ struct drm_fb_helper *msm_fbdev_init(struct drm_device *dev)
 
        fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL);
        if (!fbdev)
-               goto fail;
+               return NULL;
 
        helper = &fbdev->base;