mm/hwpoison: pass pfn to num_poisoned_pages_*()
authorNaoya Horiguchi <naoya.horiguchi@nec.com>
Mon, 24 Oct 2022 06:20:11 +0000 (15:20 +0900)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 9 Nov 2022 01:37:22 +0000 (17:37 -0800)
No functional change.

Link: https://lkml.kernel.org/r/20221024062012.1520887-4-naoya.horiguchi@linux.dev
Signed-off-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Jane Chu <jane.chu@oracle.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Yang Shi <shy828301@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
arch/parisc/kernel/pdt.c
include/linux/mm.h
mm/memory-failure.c

index fdc880e2575a569a366bcc3cc2900636c10f526e..80943a00e2459425c9988562b3d684960317917f 100644 (file)
@@ -231,7 +231,7 @@ void __init pdc_pdt_init(void)
 
                /* mark memory page bad */
                memblock_reserve(pdt_entry[i] & PAGE_MASK, PAGE_SIZE);
-               num_poisoned_pages_inc();
+               num_poisoned_pages_inc(addr >> PAGE_SHIFT);
        }
 }
 
index c667a6c4b657eb42238d68e1e22a73a1fdec7d68..78ae2ee09a24c6646303dfc9c2b053f80cbb1f00 100644 (file)
@@ -3279,7 +3279,7 @@ extern int soft_offline_page(unsigned long pfn, int flags);
 #ifdef CONFIG_MEMORY_FAILURE
 extern int __get_huge_page_for_hwpoison(unsigned long pfn, int flags,
                                        bool *migratable_cleared);
-extern void num_poisoned_pages_inc(void);
+extern void num_poisoned_pages_inc(unsigned long pfn);
 #else
 static inline int __get_huge_page_for_hwpoison(unsigned long pfn, int flags,
                                        bool *migratable_cleared)
@@ -3287,7 +3287,7 @@ static inline int __get_huge_page_for_hwpoison(unsigned long pfn, int flags,
        return 0;
 }
 
-static inline void num_poisoned_pages_inc(void)
+static inline void num_poisoned_pages_inc(unsigned long pfn)
 {
 }
 #endif
index 44d7bf6ff214e3c5e48d4e351cc536f69cd5d7db..757a46e172dedb0c94653c2b018d13447899e241 100644 (file)
@@ -74,12 +74,12 @@ atomic_long_t num_poisoned_pages __read_mostly = ATOMIC_LONG_INIT(0);
 
 static bool hw_memory_failure __read_mostly = false;
 
-inline void num_poisoned_pages_inc(void)
+inline void num_poisoned_pages_inc(unsigned long pfn)
 {
        atomic_long_inc(&num_poisoned_pages);
 }
 
-static inline void num_poisoned_pages_sub(long i)
+static inline void num_poisoned_pages_sub(unsigned long pfn, long i)
 {
        atomic_long_sub(i, &num_poisoned_pages);
 }
@@ -125,7 +125,7 @@ static bool page_handle_poison(struct page *page, bool hugepage_or_freepage, boo
        if (release)
                put_page(page);
        page_ref_inc(page);
-       num_poisoned_pages_inc();
+       num_poisoned_pages_inc(page_to_pfn(page));
 
        return true;
 }
@@ -1194,7 +1194,7 @@ static int action_result(unsigned long pfn, enum mf_action_page_type type,
 {
        trace_memory_failure_event(pfn, type, result);
 
-       num_poisoned_pages_inc();
+       num_poisoned_pages_inc(pfn);
        pr_err("%#lx: recovery action for %s: %s\n",
                pfn, action_page_types[type], action_name[result]);
 
@@ -1741,7 +1741,7 @@ static int hugetlb_set_page_hwpoison(struct page *hpage, struct page *page)
                llist_add(&raw_hwp->node, head);
                /* the first error event will be counted in action_result(). */
                if (ret)
-                       num_poisoned_pages_inc();
+                       num_poisoned_pages_inc(page_to_pfn(page));
        } else {
                /*
                 * Failed to save raw error info.  We no longer trace all
@@ -2414,7 +2414,7 @@ int unpoison_memory(unsigned long pfn)
 unlock_mutex:
        mutex_unlock(&mf_mutex);
        if (!ret || freeit) {
-               num_poisoned_pages_sub(count);
+               num_poisoned_pages_sub(pfn, count);
                unpoison_pr_info("Unpoison: Software-unpoisoned page %#lx\n",
                                 page_to_pfn(p), &unpoison_rs);
        }
@@ -2630,5 +2630,5 @@ void clear_hwpoisoned_pages(struct page *memmap, int nr_pages)
                }
        }
        if (total)
-               num_poisoned_pages_sub(total);
+               num_poisoned_pages_sub(0, total);
 }