bnx2x: unlock before returning an error
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 24 Jan 2012 21:59:31 +0000 (21:59 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 25 Jan 2012 21:58:26 +0000 (16:58 -0500)
We introduced a new return here but forgot to drop the lock.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c

index cb6339c35571f6a9d86b85d92324fb4680b80406..69465c32e5f617c040d7f1f6eb8359a46d7fdc44 100644 (file)
@@ -1836,6 +1836,7 @@ static int bnx2x_vlan_mac_del_all(struct bnx2x *bp,
                        rc = exeq->remove(bp, exeq->owner, exeq_pos);
                        if (rc) {
                                BNX2X_ERR("Failed to remove command\n");
+                               spin_unlock_bh(&exeq->lock);
                                return rc;
                        }
                        list_del(&exeq_pos->link);