firmware: arm_scmi: Make SMC transport a standalone driver
authorCristian Marussi <cristian.marussi@arm.com>
Mon, 12 Aug 2024 17:33:37 +0000 (18:33 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Fri, 16 Aug 2024 09:26:06 +0000 (10:26 +0100)
Make SCMI SMC transport a standalone driver that can be optionally
loaded as a module.

CC: Peng Fan <peng.fan@nxp.com>
CC: Nikunj Kela <quic_nkela@quicinc.com>
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Message-Id: <20240812173340.3912830-7-cristian.marussi@arm.com>
[sudeep.holla: moved Clang Thumb2 build fix to the new makefile]
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/Kconfig
drivers/firmware/arm_scmi/Makefile
drivers/firmware/arm_scmi/common.h
drivers/firmware/arm_scmi/driver.c
drivers/firmware/arm_scmi/smc.c [deleted file]
drivers/firmware/arm_scmi/transports/Kconfig
drivers/firmware/arm_scmi/transports/Makefile
drivers/firmware/arm_scmi/transports/smc.c [new file with mode: 0644]

index e9a7c9aaa9568735be9ad4f29aa8d4b1e216e922..27de15ad6444f28633285ad878a0f893f22d8e75 100644 (file)
@@ -84,32 +84,6 @@ config ARM_SCMI_TRANSPORT_OPTEE
          If you want the ARM SCMI PROTOCOL stack to include support for a
          transport based on OP-TEE SCMI service, answer Y.
 
-config ARM_SCMI_TRANSPORT_SMC
-       bool "SCMI transport based on SMC"
-       depends on HAVE_ARM_SMCCC_DISCOVERY
-       select ARM_SCMI_HAVE_TRANSPORT
-       select ARM_SCMI_HAVE_SHMEM
-       default y
-       help
-         Enable SMC based transport for SCMI.
-
-         If you want the ARM SCMI PROTOCOL stack to include support for a
-         transport based on SMC, answer Y.
-
-config ARM_SCMI_TRANSPORT_SMC_ATOMIC_ENABLE
-       bool "Enable atomic mode support for SCMI SMC transport"
-       depends on ARM_SCMI_TRANSPORT_SMC
-       help
-         Enable support of atomic operation for SCMI SMC based transport.
-
-         If you want the SCMI SMC based transport to operate in atomic
-         mode, avoiding any kind of sleeping behaviour for selected
-         transactions on the TX path, answer Y.
-         Enabling atomic mode operations allows any SCMI driver using this
-         transport to optionally ask for atomic SCMI transactions and operate
-         in atomic context too, at the price of using a number of busy-waiting
-         primitives all over instead. If unsure say N.
-
 config ARM_SCMI_TRANSPORT_VIRTIO
        bool "SCMI transport based on VirtIO"
        depends on VIRTIO=y || VIRTIO=ARM_SCMI_PROTOCOL
index beaa55c146b87b124736800fb94e3c03446fb113..4c58c668ecc4c63afa1a2929f4a6e6104502a89a 100644 (file)
@@ -5,7 +5,6 @@ scmi-core-objs := $(scmi-bus-y)
 scmi-driver-y = driver.o notify.o
 scmi-driver-$(CONFIG_ARM_SCMI_RAW_MODE_SUPPORT) += raw_mode.o
 scmi-transport-$(CONFIG_ARM_SCMI_HAVE_SHMEM) = shmem.o
-scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_SMC) += smc.o
 scmi-transport-$(CONFIG_ARM_SCMI_HAVE_MSG) += msg.o
 scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_VIRTIO) += virtio.o
 scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_OPTEE) += optee.o
@@ -19,10 +18,3 @@ obj-$(CONFIG_ARM_SCMI_PROTOCOL) += scmi-core.o
 obj-$(CONFIG_ARM_SCMI_PROTOCOL) += scmi-module.o
 
 obj-$(CONFIG_ARM_SCMI_POWER_CONTROL) += scmi_power_control.o
-
-ifeq ($(CONFIG_THUMB2_KERNEL)$(CONFIG_CC_IS_CLANG),yy)
-# The use of R7 in the SMCCC conflicts with the compiler's use of R7 as a frame
-# pointer in Thumb2 mode, which is forcibly enabled by Clang when profiling
-# hooks are inserted via the -pg switch.
-CFLAGS_REMOVE_smc.o += $(CC_FLAGS_FTRACE)
-endif
index 2bca62a8ecde2448eaffd74ca246bd8b39395734..231b061dadb9ba793b00bca2ffae7cbd7353572b 100644 (file)
@@ -286,9 +286,6 @@ int scmi_xfer_raw_inflight_register(const struct scmi_handle *handle,
 int scmi_xfer_raw_wait_for_message_response(struct scmi_chan_info *cinfo,
                                            struct scmi_xfer *xfer,
                                            unsigned int timeout_ms);
-#ifdef CONFIG_ARM_SCMI_TRANSPORT_SMC
-extern const struct scmi_desc scmi_smc_desc;
-#endif
 #ifdef CONFIG_ARM_SCMI_TRANSPORT_VIRTIO
 extern const struct scmi_desc scmi_virtio_desc;
 #endif
index c13bef8a1796a31bcb18a636a72ddb6dc93dffdc..bdb952c385d217ccab8df3c00c535ba06ddb015e 100644 (file)
@@ -3321,11 +3321,6 @@ static const struct of_device_id scmi_of_match[] = {
 #ifdef CONFIG_ARM_SCMI_TRANSPORT_OPTEE
        { .compatible = "linaro,scmi-optee", .data = &scmi_optee_desc },
 #endif
-#ifdef CONFIG_ARM_SCMI_TRANSPORT_SMC
-       { .compatible = "arm,scmi-smc", .data = &scmi_smc_desc},
-       { .compatible = "arm,scmi-smc-param", .data = &scmi_smc_desc},
-       { .compatible = "qcom,scmi-smc", .data = &scmi_smc_desc},
-#endif
 #ifdef CONFIG_ARM_SCMI_TRANSPORT_VIRTIO
        { .compatible = "arm,scmi-virtio", .data = &scmi_virtio_desc},
 #endif
diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c
deleted file mode 100644 (file)
index 4cb8638..0000000
+++ /dev/null
@@ -1,288 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/*
- * System Control and Management Interface (SCMI) Message SMC/HVC
- * Transport driver
- *
- * Copyright 2020 NXP
- */
-
-#include <linux/arm-smccc.h>
-#include <linux/atomic.h>
-#include <linux/device.h>
-#include <linux/err.h>
-#include <linux/interrupt.h>
-#include <linux/mutex.h>
-#include <linux/of.h>
-#include <linux/of_address.h>
-#include <linux/of_irq.h>
-#include <linux/limits.h>
-#include <linux/processor.h>
-#include <linux/slab.h>
-
-#include "common.h"
-
-/*
- * The shmem address is split into 4K page and offset.
- * This is to make sure the parameters fit in 32bit arguments of the
- * smc/hvc call to keep it uniform across smc32/smc64 conventions.
- * This however limits the shmem address to 44 bit.
- *
- * These optional parameters can be used to distinguish among multiple
- * scmi instances that are using the same smc-id.
- * The page parameter is passed in r1/x1/w1 register and the offset parameter
- * is passed in r2/x2/w2 register.
- */
-
-#define SHMEM_SIZE (SZ_4K)
-#define SHMEM_SHIFT 12
-#define SHMEM_PAGE(x) (_UL((x) >> SHMEM_SHIFT))
-#define SHMEM_OFFSET(x) ((x) & (SHMEM_SIZE - 1))
-
-/**
- * struct scmi_smc - Structure representing a SCMI smc transport
- *
- * @irq: An optional IRQ for completion
- * @cinfo: SCMI channel info
- * @shmem: Transmit/Receive shared memory area
- * @shmem_lock: Lock to protect access to Tx/Rx shared memory area.
- *             Used when NOT operating in atomic mode.
- * @inflight: Atomic flag to protect access to Tx/Rx shared memory area.
- *           Used when operating in atomic mode.
- * @func_id: smc/hvc call function id
- * @param_page: 4K page number of the shmem channel
- * @param_offset: Offset within the 4K page of the shmem channel
- * @cap_id: smc/hvc doorbell's capability id to be used on Qualcomm virtual
- *         platforms
- */
-
-struct scmi_smc {
-       int irq;
-       struct scmi_chan_info *cinfo;
-       struct scmi_shared_mem __iomem *shmem;
-       /* Protect access to shmem area */
-       struct mutex shmem_lock;
-#define INFLIGHT_NONE  MSG_TOKEN_MAX
-       atomic_t inflight;
-       unsigned long func_id;
-       unsigned long param_page;
-       unsigned long param_offset;
-       unsigned long cap_id;
-};
-
-static irqreturn_t smc_msg_done_isr(int irq, void *data)
-{
-       struct scmi_smc *scmi_info = data;
-
-       scmi_rx_callback(scmi_info->cinfo,
-                        scmi_shmem_ops.read_header(scmi_info->shmem), NULL);
-
-       return IRQ_HANDLED;
-}
-
-static bool smc_chan_available(struct device_node *of_node, int idx)
-{
-       struct device_node *np = of_parse_phandle(of_node, "shmem", 0);
-       if (!np)
-               return false;
-
-       of_node_put(np);
-       return true;
-}
-
-static inline void smc_channel_lock_init(struct scmi_smc *scmi_info)
-{
-       if (IS_ENABLED(CONFIG_ARM_SCMI_TRANSPORT_SMC_ATOMIC_ENABLE))
-               atomic_set(&scmi_info->inflight, INFLIGHT_NONE);
-       else
-               mutex_init(&scmi_info->shmem_lock);
-}
-
-static bool smc_xfer_inflight(struct scmi_xfer *xfer, atomic_t *inflight)
-{
-       int ret;
-
-       ret = atomic_cmpxchg(inflight, INFLIGHT_NONE, xfer->hdr.seq);
-
-       return ret == INFLIGHT_NONE;
-}
-
-static inline void
-smc_channel_lock_acquire(struct scmi_smc *scmi_info,
-                        struct scmi_xfer *xfer __maybe_unused)
-{
-       if (IS_ENABLED(CONFIG_ARM_SCMI_TRANSPORT_SMC_ATOMIC_ENABLE))
-               spin_until_cond(smc_xfer_inflight(xfer, &scmi_info->inflight));
-       else
-               mutex_lock(&scmi_info->shmem_lock);
-}
-
-static inline void smc_channel_lock_release(struct scmi_smc *scmi_info)
-{
-       if (IS_ENABLED(CONFIG_ARM_SCMI_TRANSPORT_SMC_ATOMIC_ENABLE))
-               atomic_set(&scmi_info->inflight, INFLIGHT_NONE);
-       else
-               mutex_unlock(&scmi_info->shmem_lock);
-}
-
-static int smc_chan_setup(struct scmi_chan_info *cinfo, struct device *dev,
-                         bool tx)
-{
-       struct device *cdev = cinfo->dev;
-       unsigned long cap_id = ULONG_MAX;
-       struct scmi_smc *scmi_info;
-       struct resource res = {};
-       u32 func_id;
-       int ret;
-
-       if (!tx)
-               return -ENODEV;
-
-       scmi_info = devm_kzalloc(dev, sizeof(*scmi_info), GFP_KERNEL);
-       if (!scmi_info)
-               return -ENOMEM;
-
-       scmi_info->shmem = scmi_shmem_ops.setup_iomap(cinfo, dev, tx, &res);
-       if (IS_ERR(scmi_info->shmem))
-               return PTR_ERR(scmi_info->shmem);
-
-       ret = of_property_read_u32(dev->of_node, "arm,smc-id", &func_id);
-       if (ret < 0)
-               return ret;
-
-       if (of_device_is_compatible(dev->of_node, "qcom,scmi-smc")) {
-               resource_size_t size = resource_size(&res);
-               void __iomem *ptr = (void __iomem *)scmi_info->shmem + size - 8;
-               /* The capability-id is kept in last 8 bytes of shmem.
-                *     +-------+ <-- 0
-                *     | shmem |
-                *     +-------+ <-- size - 8
-                *     | capId |
-                *     +-------+ <-- size
-                */
-               memcpy_fromio(&cap_id, ptr, sizeof(cap_id));
-       }
-
-       if (of_device_is_compatible(dev->of_node, "arm,scmi-smc-param")) {
-               scmi_info->param_page = SHMEM_PAGE(res.start);
-               scmi_info->param_offset = SHMEM_OFFSET(res.start);
-       }
-       /*
-        * If there is an interrupt named "a2p", then the service and
-        * completion of a message is signaled by an interrupt rather than by
-        * the return of the SMC call.
-        */
-       scmi_info->irq = of_irq_get_byname(cdev->of_node, "a2p");
-       if (scmi_info->irq > 0) {
-               ret = request_irq(scmi_info->irq, smc_msg_done_isr,
-                                 IRQF_NO_SUSPEND, dev_name(dev), scmi_info);
-               if (ret) {
-                       dev_err(dev, "failed to setup SCMI smc irq\n");
-                       return ret;
-               }
-       } else {
-               cinfo->no_completion_irq = true;
-       }
-
-       scmi_info->func_id = func_id;
-       scmi_info->cap_id = cap_id;
-       scmi_info->cinfo = cinfo;
-       smc_channel_lock_init(scmi_info);
-       cinfo->transport_info = scmi_info;
-
-       return 0;
-}
-
-static int smc_chan_free(int id, void *p, void *data)
-{
-       struct scmi_chan_info *cinfo = p;
-       struct scmi_smc *scmi_info = cinfo->transport_info;
-
-       /*
-        * Different protocols might share the same chan info, so a previous
-        * smc_chan_free call might have already freed the structure.
-        */
-       if (!scmi_info)
-               return 0;
-
-       /* Ignore any possible further reception on the IRQ path */
-       if (scmi_info->irq > 0)
-               free_irq(scmi_info->irq, scmi_info);
-
-       cinfo->transport_info = NULL;
-       scmi_info->cinfo = NULL;
-
-       return 0;
-}
-
-static int smc_send_message(struct scmi_chan_info *cinfo,
-                           struct scmi_xfer *xfer)
-{
-       struct scmi_smc *scmi_info = cinfo->transport_info;
-       struct arm_smccc_res res;
-
-       /*
-        * Channel will be released only once response has been
-        * surely fully retrieved, so after .mark_txdone()
-        */
-       smc_channel_lock_acquire(scmi_info, xfer);
-
-       scmi_shmem_ops.tx_prepare(scmi_info->shmem, xfer, cinfo);
-
-       if (scmi_info->cap_id != ULONG_MAX)
-               arm_smccc_1_1_invoke(scmi_info->func_id, scmi_info->cap_id, 0,
-                                    0, 0, 0, 0, 0, &res);
-       else
-               arm_smccc_1_1_invoke(scmi_info->func_id, scmi_info->param_page,
-                                    scmi_info->param_offset, 0, 0, 0, 0, 0,
-                                    &res);
-
-       /* Only SMCCC_RET_NOT_SUPPORTED is valid error code */
-       if (res.a0) {
-               smc_channel_lock_release(scmi_info);
-               return -EOPNOTSUPP;
-       }
-
-       return 0;
-}
-
-static void smc_fetch_response(struct scmi_chan_info *cinfo,
-                              struct scmi_xfer *xfer)
-{
-       struct scmi_smc *scmi_info = cinfo->transport_info;
-
-       scmi_shmem_ops.fetch_response(scmi_info->shmem, xfer);
-}
-
-static void smc_mark_txdone(struct scmi_chan_info *cinfo, int ret,
-                           struct scmi_xfer *__unused)
-{
-       struct scmi_smc *scmi_info = cinfo->transport_info;
-
-       smc_channel_lock_release(scmi_info);
-}
-
-static const struct scmi_transport_ops scmi_smc_ops = {
-       .chan_available = smc_chan_available,
-       .chan_setup = smc_chan_setup,
-       .chan_free = smc_chan_free,
-       .send_message = smc_send_message,
-       .mark_txdone = smc_mark_txdone,
-       .fetch_response = smc_fetch_response,
-};
-
-const struct scmi_desc scmi_smc_desc = {
-       .ops = &scmi_smc_ops,
-       .max_rx_timeout_ms = 30,
-       .max_msg = 20,
-       .max_msg_size = 128,
-       /*
-        * Setting .sync_cmds_atomic_replies to true for SMC assumes that,
-        * once the SMC instruction has completed successfully, the issued
-        * SCMI command would have been already fully processed by the SCMI
-        * platform firmware and so any possible response value expected
-        * for the issued command will be immmediately ready to be fetched
-        * from the shared memory area.
-        */
-       .sync_cmds_completed_on_ret = true,
-       .atomic_enabled = IS_ENABLED(CONFIG_ARM_SCMI_TRANSPORT_SMC_ATOMIC_ENABLE),
-};
index 96c0d76b30426bb3a1aab1cb7d45036b439113ab..85d693811a1cbaf95f1748f5372d949d89f88726 100644 (file)
@@ -34,4 +34,32 @@ config ARM_SCMI_TRANSPORT_MAILBOX
          This driver can also be built as a module. If so, the module
          will be called scmi_transport_mailbox.
 
+config ARM_SCMI_TRANSPORT_SMC
+       tristate "SCMI transport based on SMC"
+       depends on HAVE_ARM_SMCCC_DISCOVERY
+       select ARM_SCMI_HAVE_TRANSPORT
+       select ARM_SCMI_HAVE_SHMEM
+       default y
+       help
+         Enable SMC based transport for SCMI.
+
+         If you want the ARM SCMI PROTOCOL stack to include support for a
+         transport based on SMC, answer Y.
+         This driver can also be built as a module. If so, the module
+         will be called scmi_transport_smc.
+
+config ARM_SCMI_TRANSPORT_SMC_ATOMIC_ENABLE
+       bool "Enable atomic mode support for SCMI SMC transport"
+       depends on ARM_SCMI_TRANSPORT_SMC
+       help
+         Enable support of atomic operation for SCMI SMC based transport.
+
+         If you want the SCMI SMC based transport to operate in atomic
+         mode, avoiding any kind of sleeping behaviour for selected
+         transactions on the TX path, answer Y.
+         Enabling atomic mode operations allows any SCMI driver using this
+         transport to optionally ask for atomic SCMI transactions and operate
+         in atomic context too, at the price of using a number of busy-waiting
+         primitives all over instead. If unsure say N.
+
 endmenu
index cb40be8955be5981ef155cc9f0f45d05aa0f6b6e..080bd76d9dbda44228f0d386c5409921b1a5b824 100644 (file)
@@ -1,4 +1,12 @@
 # SPDX-License-Identifier: GPL-2.0-only
 scmi_transport_mailbox-objs := mailbox.o
 obj-$(CONFIG_ARM_SCMI_TRANSPORT_MAILBOX) += scmi_transport_mailbox.o
+scmi_transport_smc-objs := smc.o
+obj-$(CONFIG_ARM_SCMI_TRANSPORT_SMC) += scmi_transport_smc.o
 
+ifeq ($(CONFIG_THUMB2_KERNEL)$(CONFIG_CC_IS_CLANG),yy)
+# The use of R7 in the SMCCC conflicts with the compiler's use of R7 as a frame
+# pointer in Thumb2 mode, which is forcibly enabled by Clang when profiling
+# hooks are inserted via the -pg switch.
+CFLAGS_REMOVE_smc.o += $(CC_FLAGS_FTRACE)
+endif
diff --git a/drivers/firmware/arm_scmi/transports/smc.c b/drivers/firmware/arm_scmi/transports/smc.c
new file mode 100644 (file)
index 0000000..6fc3e19
--- /dev/null
@@ -0,0 +1,307 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * System Control and Management Interface (SCMI) Message SMC/HVC
+ * Transport driver
+ *
+ * Copyright 2020 NXP
+ */
+
+#include <linux/arm-smccc.h>
+#include <linux/atomic.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/interrupt.h>
+#include <linux/mutex.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
+#include <linux/limits.h>
+#include <linux/platform_device.h>
+#include <linux/processor.h>
+#include <linux/slab.h>
+
+#include "../common.h"
+
+/*
+ * The shmem address is split into 4K page and offset.
+ * This is to make sure the parameters fit in 32bit arguments of the
+ * smc/hvc call to keep it uniform across smc32/smc64 conventions.
+ * This however limits the shmem address to 44 bit.
+ *
+ * These optional parameters can be used to distinguish among multiple
+ * scmi instances that are using the same smc-id.
+ * The page parameter is passed in r1/x1/w1 register and the offset parameter
+ * is passed in r2/x2/w2 register.
+ */
+
+#define SHMEM_SIZE (SZ_4K)
+#define SHMEM_SHIFT 12
+#define SHMEM_PAGE(x) (_UL((x) >> SHMEM_SHIFT))
+#define SHMEM_OFFSET(x) ((x) & (SHMEM_SIZE - 1))
+
+/**
+ * struct scmi_smc - Structure representing a SCMI smc transport
+ *
+ * @irq: An optional IRQ for completion
+ * @cinfo: SCMI channel info
+ * @shmem: Transmit/Receive shared memory area
+ * @shmem_lock: Lock to protect access to Tx/Rx shared memory area.
+ *             Used when NOT operating in atomic mode.
+ * @inflight: Atomic flag to protect access to Tx/Rx shared memory area.
+ *           Used when operating in atomic mode.
+ * @func_id: smc/hvc call function id
+ * @param_page: 4K page number of the shmem channel
+ * @param_offset: Offset within the 4K page of the shmem channel
+ * @cap_id: smc/hvc doorbell's capability id to be used on Qualcomm virtual
+ *         platforms
+ */
+
+struct scmi_smc {
+       int irq;
+       struct scmi_chan_info *cinfo;
+       struct scmi_shared_mem __iomem *shmem;
+       /* Protect access to shmem area */
+       struct mutex shmem_lock;
+#define INFLIGHT_NONE  MSG_TOKEN_MAX
+       atomic_t inflight;
+       unsigned long func_id;
+       unsigned long param_page;
+       unsigned long param_offset;
+       unsigned long cap_id;
+};
+
+static struct scmi_transport_core_operations *core;
+
+static irqreturn_t smc_msg_done_isr(int irq, void *data)
+{
+       struct scmi_smc *scmi_info = data;
+
+       core->rx_callback(scmi_info->cinfo,
+                         core->shmem->read_header(scmi_info->shmem), NULL);
+
+       return IRQ_HANDLED;
+}
+
+static bool smc_chan_available(struct device_node *of_node, int idx)
+{
+       struct device_node *np = of_parse_phandle(of_node, "shmem", 0);
+       if (!np)
+               return false;
+
+       of_node_put(np);
+       return true;
+}
+
+static inline void smc_channel_lock_init(struct scmi_smc *scmi_info)
+{
+       if (IS_ENABLED(CONFIG_ARM_SCMI_TRANSPORT_SMC_ATOMIC_ENABLE))
+               atomic_set(&scmi_info->inflight, INFLIGHT_NONE);
+       else
+               mutex_init(&scmi_info->shmem_lock);
+}
+
+static bool smc_xfer_inflight(struct scmi_xfer *xfer, atomic_t *inflight)
+{
+       int ret;
+
+       ret = atomic_cmpxchg(inflight, INFLIGHT_NONE, xfer->hdr.seq);
+
+       return ret == INFLIGHT_NONE;
+}
+
+static inline void
+smc_channel_lock_acquire(struct scmi_smc *scmi_info,
+                        struct scmi_xfer *xfer __maybe_unused)
+{
+       if (IS_ENABLED(CONFIG_ARM_SCMI_TRANSPORT_SMC_ATOMIC_ENABLE))
+               spin_until_cond(smc_xfer_inflight(xfer, &scmi_info->inflight));
+       else
+               mutex_lock(&scmi_info->shmem_lock);
+}
+
+static inline void smc_channel_lock_release(struct scmi_smc *scmi_info)
+{
+       if (IS_ENABLED(CONFIG_ARM_SCMI_TRANSPORT_SMC_ATOMIC_ENABLE))
+               atomic_set(&scmi_info->inflight, INFLIGHT_NONE);
+       else
+               mutex_unlock(&scmi_info->shmem_lock);
+}
+
+static int smc_chan_setup(struct scmi_chan_info *cinfo, struct device *dev,
+                         bool tx)
+{
+       struct device *cdev = cinfo->dev;
+       unsigned long cap_id = ULONG_MAX;
+       struct scmi_smc *scmi_info;
+       struct resource res = {};
+       u32 func_id;
+       int ret;
+
+       if (!tx)
+               return -ENODEV;
+
+       scmi_info = devm_kzalloc(dev, sizeof(*scmi_info), GFP_KERNEL);
+       if (!scmi_info)
+               return -ENOMEM;
+
+       scmi_info->shmem = core->shmem->setup_iomap(cinfo, dev, tx, &res);
+       if (IS_ERR(scmi_info->shmem))
+               return PTR_ERR(scmi_info->shmem);
+
+       ret = of_property_read_u32(dev->of_node, "arm,smc-id", &func_id);
+       if (ret < 0)
+               return ret;
+
+       if (of_device_is_compatible(dev->of_node, "qcom,scmi-smc")) {
+               resource_size_t size = resource_size(&res);
+               void __iomem *ptr = (void __iomem *)scmi_info->shmem + size - 8;
+               /* The capability-id is kept in last 8 bytes of shmem.
+                *     +-------+ <-- 0
+                *     | shmem |
+                *     +-------+ <-- size - 8
+                *     | capId |
+                *     +-------+ <-- size
+                */
+               memcpy_fromio(&cap_id, ptr, sizeof(cap_id));
+       }
+
+       if (of_device_is_compatible(dev->of_node, "arm,scmi-smc-param")) {
+               scmi_info->param_page = SHMEM_PAGE(res.start);
+               scmi_info->param_offset = SHMEM_OFFSET(res.start);
+       }
+       /*
+        * If there is an interrupt named "a2p", then the service and
+        * completion of a message is signaled by an interrupt rather than by
+        * the return of the SMC call.
+        */
+       scmi_info->irq = of_irq_get_byname(cdev->of_node, "a2p");
+       if (scmi_info->irq > 0) {
+               ret = request_irq(scmi_info->irq, smc_msg_done_isr,
+                                 IRQF_NO_SUSPEND, dev_name(dev), scmi_info);
+               if (ret) {
+                       dev_err(dev, "failed to setup SCMI smc irq\n");
+                       return ret;
+               }
+       } else {
+               cinfo->no_completion_irq = true;
+       }
+
+       scmi_info->func_id = func_id;
+       scmi_info->cap_id = cap_id;
+       scmi_info->cinfo = cinfo;
+       smc_channel_lock_init(scmi_info);
+       cinfo->transport_info = scmi_info;
+
+       return 0;
+}
+
+static int smc_chan_free(int id, void *p, void *data)
+{
+       struct scmi_chan_info *cinfo = p;
+       struct scmi_smc *scmi_info = cinfo->transport_info;
+
+       /*
+        * Different protocols might share the same chan info, so a previous
+        * smc_chan_free call might have already freed the structure.
+        */
+       if (!scmi_info)
+               return 0;
+
+       /* Ignore any possible further reception on the IRQ path */
+       if (scmi_info->irq > 0)
+               free_irq(scmi_info->irq, scmi_info);
+
+       cinfo->transport_info = NULL;
+       scmi_info->cinfo = NULL;
+
+       return 0;
+}
+
+static int smc_send_message(struct scmi_chan_info *cinfo,
+                           struct scmi_xfer *xfer)
+{
+       struct scmi_smc *scmi_info = cinfo->transport_info;
+       struct arm_smccc_res res;
+
+       /*
+        * Channel will be released only once response has been
+        * surely fully retrieved, so after .mark_txdone()
+        */
+       smc_channel_lock_acquire(scmi_info, xfer);
+
+       core->shmem->tx_prepare(scmi_info->shmem, xfer, cinfo);
+
+       if (scmi_info->cap_id != ULONG_MAX)
+               arm_smccc_1_1_invoke(scmi_info->func_id, scmi_info->cap_id, 0,
+                                    0, 0, 0, 0, 0, &res);
+       else
+               arm_smccc_1_1_invoke(scmi_info->func_id, scmi_info->param_page,
+                                    scmi_info->param_offset, 0, 0, 0, 0, 0,
+                                    &res);
+
+       /* Only SMCCC_RET_NOT_SUPPORTED is valid error code */
+       if (res.a0) {
+               smc_channel_lock_release(scmi_info);
+               return -EOPNOTSUPP;
+       }
+
+       return 0;
+}
+
+static void smc_fetch_response(struct scmi_chan_info *cinfo,
+                              struct scmi_xfer *xfer)
+{
+       struct scmi_smc *scmi_info = cinfo->transport_info;
+
+       core->shmem->fetch_response(scmi_info->shmem, xfer);
+}
+
+static void smc_mark_txdone(struct scmi_chan_info *cinfo, int ret,
+                           struct scmi_xfer *__unused)
+{
+       struct scmi_smc *scmi_info = cinfo->transport_info;
+
+       smc_channel_lock_release(scmi_info);
+}
+
+static const struct scmi_transport_ops scmi_smc_ops = {
+       .chan_available = smc_chan_available,
+       .chan_setup = smc_chan_setup,
+       .chan_free = smc_chan_free,
+       .send_message = smc_send_message,
+       .mark_txdone = smc_mark_txdone,
+       .fetch_response = smc_fetch_response,
+};
+
+static const struct scmi_desc scmi_smc_desc = {
+       .ops = &scmi_smc_ops,
+       .max_rx_timeout_ms = 30,
+       .max_msg = 20,
+       .max_msg_size = 128,
+       /*
+        * Setting .sync_cmds_atomic_replies to true for SMC assumes that,
+        * once the SMC instruction has completed successfully, the issued
+        * SCMI command would have been already fully processed by the SCMI
+        * platform firmware and so any possible response value expected
+        * for the issued command will be immmediately ready to be fetched
+        * from the shared memory area.
+        */
+       .sync_cmds_completed_on_ret = true,
+       .atomic_enabled = IS_ENABLED(CONFIG_ARM_SCMI_TRANSPORT_SMC_ATOMIC_ENABLE),
+};
+
+static const struct of_device_id scmi_of_match[] = {
+       { .compatible = "arm,scmi-smc" },
+       { .compatible = "arm,scmi-smc-param" },
+       { .compatible = "qcom,scmi-smc" },
+       { /* Sentinel */ },
+};
+
+DEFINE_SCMI_TRANSPORT_DRIVER(scmi_smc, scmi_smc_driver, scmi_smc_desc,
+                            scmi_of_match, core);
+module_platform_driver(scmi_smc_driver);
+
+MODULE_AUTHOR("Peng Fan <peng.fan@nxp.com>");
+MODULE_AUTHOR("Nikunj Kela <quic_nkela@quicinc.com>");
+MODULE_DESCRIPTION("SCMI SMC Transport driver");
+MODULE_LICENSE("GPL");