drm/xe: Removing extra mem_access protection from runtime pm
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 17 Apr 2024 20:39:49 +0000 (16:39 -0400)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 18 Apr 2024 12:31:40 +0000 (08:31 -0400)
This is not needed any longer, now that we have all the protection
in place with the runtime pm itself.

Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240417203952.25503-7-rodrigo.vivi@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_device.c
drivers/gpu/drm/xe/xe_device.h
drivers/gpu/drm/xe/xe_pm.c

index 4b38fb78adca7aa04b2415a795a13c48eec575b7..1f8f9018b27c9fbb0142022869aec4b7ec57aad6 100644 (file)
@@ -717,14 +717,6 @@ u32 xe_device_ccs_bytes(struct xe_device *xe, u64 size)
                DIV_ROUND_UP_ULL(size, NUM_BYTES_PER_CCS_BYTE(xe)) : 0;
 }
 
-bool xe_device_mem_access_ongoing(struct xe_device *xe)
-{
-       if (xe_pm_read_callback_task(xe) != NULL)
-               return true;
-
-       return atomic_read(&xe->mem_access.ref);
-}
-
 /**
  * xe_device_assert_mem_access - Inspect the current runtime_pm state.
  * @xe: xe device instance
index 02eda661097217284f6a430eafd9bd2712a009f5..39921666e1f12dbcf0980f33f4b6cae6c0ad1320 100644 (file)
@@ -138,7 +138,6 @@ bool xe_device_mem_access_get_if_ongoing(struct xe_device *xe);
 void xe_device_mem_access_put(struct xe_device *xe);
 
 void xe_device_assert_mem_access(struct xe_device *xe);
-bool xe_device_mem_access_ongoing(struct xe_device *xe);
 
 static inline bool xe_device_in_fault_mode(struct xe_device *xe)
 {
index a1a13d17aa78745f4795cf75f51f271482a15d20..0d5fbd715a25492fde589330ac08316a055c4e05 100644 (file)
@@ -306,9 +306,6 @@ int xe_pm_runtime_suspend(struct xe_device *xe)
        u8 id;
        int err = 0;
 
-       if (xe->d3cold.allowed && xe_device_mem_access_ongoing(xe))
-               return -EBUSY;
-
        /* Disable access_ongoing asserts and prevent recursive pm calls */
        xe_pm_write_callback_task(xe, current);