hwmon: (emc2305) Remove unnecessary range check

Static analyzers report:

drivers/hwmon/emc2305.c:194 emc2305_set_cur_state()
	warn: impossible condition '(val > 255) => (0-255 > 255)'

'val' is u8 and thus can never be larger than 255. In theory
the operation calculating 'val' could result in a value larger
than 255, but this won't happen because its parameter has already
been range checked and it is guaranteed that the result never exceeds
255. Remove the unnecessary value check.

Cc: Michael Shych <michaelsh@nvidia.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/drivers/hwmon/emc2305.c b/drivers/hwmon/emc2305.c
index ee5ed24feab5d2457243f91dc380f7db77560d6f..bb32172e07e3eaf742c8376451e5f8b3b1ebdbef 100644 (file)
--- a/drivers/hwmon/emc2305.c
+++ b/drivers/hwmon/emc2305.c
@@ -191,8 +191,6 @@ static int emc2305_set_cur_state(struct thermal_cooling_device *cdev, unsigned l
        state = max_t(unsigned long, state, data->cdev_data[cdev_idx].last_hwmon_state);
 
        val = EMC2305_PWM_STATE2DUTY(state, data->max_state, EMC2305_FAN_MAX);
-       if (val > EMC2305_FAN_MAX)
-               return -EINVAL;
 
        data->cdev_data[cdev_idx].cur_state = state;
        if (data->pwm_separate) {