ASoC: qcom: Fix sc7280 lpass potential buffer overflow
authorEvgeny Pimenov <pimenoveu12@gmail.com>
Tue, 1 Apr 2025 20:40:58 +0000 (23:40 +0300)
committerMark Brown <broonie@kernel.org>
Sun, 6 Apr 2025 22:18:17 +0000 (23:18 +0100)
Case values introduced in commit
5f78e1fb7a3e ("ASoC: qcom: Add driver support for audioreach solution")
cause out of bounds access in arrays of sc7280 driver data (e.g. in case
of RX_CODEC_DMA_RX_0 in sc7280_snd_hw_params()).

Redefine LPASS_MAX_PORTS to consider the maximum possible port id for
q6dsp as sc7280 driver utilizes some of those values.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 77d0ffef793d ("ASoC: qcom: Add macro for lpass DAI id's max limit")
Cc: stable@vger.kernel.org # v6.0+
Suggested-by: Mikhail Kobuk <m.kobuk@ispras.ru>
Suggested-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Evgeny Pimenov <pimenoveu12@gmail.com>
Link: https://patch.msgid.link/20250401204058.32261-1-pimenoveu12@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/lpass.h

index 27a2bf9a6613936787154dfd9b577f3e01bb9d12..de3ec6f594c11c9ca2f75fe9811f5ebe8640b168 100644 (file)
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <dt-bindings/sound/qcom,lpass.h>
+#include <dt-bindings/sound/qcom,q6afe.h>
 #include "lpass-hdmi.h"
 
 #define LPASS_AHBIX_CLOCK_FREQUENCY            131072000
-#define LPASS_MAX_PORTS                        (LPASS_CDC_DMA_VA_TX8 + 1)
+#define LPASS_MAX_PORTS                        (DISPLAY_PORT_RX_7 + 1)
 #define LPASS_MAX_MI2S_PORTS                   (8)
 #define LPASS_MAX_DMA_CHANNELS                 (8)
 #define LPASS_MAX_HDMI_DMA_CHANNELS            (4)