backlight: bd6107: Handle deferred probe
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 5 Mar 2024 08:11:58 +0000 (09:11 +0100)
committerLee Jones <lee@kernel.org>
Thu, 7 Mar 2024 09:03:29 +0000 (09:03 +0000)
Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240305-backlight-probe-v2-3-609b0cf24bde@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/video/backlight/bd6107.c

index c95a12bf0ce263e015c31a2ade139e6e228cbd1a..b1e7126380ef2745b669f8189caa1b54f5fc9244 100644 (file)
@@ -119,7 +119,6 @@ static int bd6107_probe(struct i2c_client *client)
        struct backlight_device *backlight;
        struct backlight_properties props;
        struct bd6107 *bd;
-       int ret;
 
        if (pdata == NULL) {
                dev_err(&client->dev, "No platform data\n");
@@ -147,11 +146,9 @@ static int bd6107_probe(struct i2c_client *client)
         * the reset.
         */
        bd->reset = devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_HIGH);
-       if (IS_ERR(bd->reset)) {
-               dev_err(&client->dev, "unable to request reset GPIO\n");
-               ret = PTR_ERR(bd->reset);
-               return ret;
-       }
+       if (IS_ERR(bd->reset))
+               return dev_err_probe(&client->dev, PTR_ERR(bd->reset),
+                                    "unable to request reset GPIO\n");
 
        memset(&props, 0, sizeof(props));
        props.type = BACKLIGHT_RAW;