media: renesas: vsp1: Name parameters to entity operations
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 13 Nov 2023 22:53:07 +0000 (00:53 +0200)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Wed, 19 Jun 2024 22:36:48 +0000 (01:36 +0300)
checkpatch.pl complains when function arguments are not named:

WARNING: function definition argument 'struct vsp1_entity *' should also have an identifier name
+       void (*configure_stream)(struct vsp1_entity *,

In preparation for reworking some of the vsp1_entity_operations
functions, fix the warnings for the existing ones.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
drivers/media/platform/renesas/vsp1/vsp1_entity.h

index f67f60677644424782e5b062ebb5aafa2595890e..42000d6e25308914d18aa9508c5b8f4d2ffc8c26 100644 (file)
@@ -77,20 +77,27 @@ struct vsp1_route {
  *             configuration.
  */
 struct vsp1_entity_operations {
-       void (*destroy)(struct vsp1_entity *);
-       void (*configure_stream)(struct vsp1_entity *, struct vsp1_pipeline *,
-                                struct vsp1_dl_list *, struct vsp1_dl_body *);
-       void (*configure_frame)(struct vsp1_entity *, struct vsp1_pipeline *,
-                               struct vsp1_dl_list *, struct vsp1_dl_body *);
-       void (*configure_partition)(struct vsp1_entity *,
-                                   struct vsp1_pipeline *,
-                                   const struct vsp1_partition *,
-                                   struct vsp1_dl_list *,
-                                   struct vsp1_dl_body *);
-       unsigned int (*max_width)(struct vsp1_entity *, struct vsp1_pipeline *);
-       void (*partition)(struct vsp1_entity *, struct vsp1_pipeline *,
-                         struct vsp1_partition *, unsigned int,
-                         struct v4l2_rect *);
+       void (*destroy)(struct vsp1_entity *entity);
+       void (*configure_stream)(struct vsp1_entity *entity,
+                                struct vsp1_pipeline *pipe,
+                                struct vsp1_dl_list *dl,
+                                struct vsp1_dl_body *dlb);
+       void (*configure_frame)(struct vsp1_entity *entity,
+                               struct vsp1_pipeline *pipe,
+                               struct vsp1_dl_list *dl,
+                               struct vsp1_dl_body *dlb);
+       void (*configure_partition)(struct vsp1_entity *entity,
+                                   struct vsp1_pipeline *pipe,
+                                   const struct vsp1_partition *partition,
+                                   struct vsp1_dl_list *dl,
+                                   struct vsp1_dl_body *dlb);
+       unsigned int (*max_width)(struct vsp1_entity *entity,
+                                 struct vsp1_pipeline *pipe);
+       void (*partition)(struct vsp1_entity *entity,
+                         struct vsp1_pipeline *pipe,
+                         struct vsp1_partition *partition,
+                         unsigned int index,
+                         struct v4l2_rect *window);
 };
 
 struct vsp1_entity {