projects
/
linux-2.6-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2cd757e
)
spi: spi-fsl-qspi: check return value after calling platform_get_resource_byname()
author
Yang Yingliang
<yangyingliang@huawei.com>
Thu, 5 May 2022 09:39:54 +0000
(17:39 +0800)
committer
Mark Brown
<broonie@kernel.org>
Mon, 9 May 2022 11:48:47 +0000
(12:48 +0100)
It will cause null-ptr-deref if platform_get_resource_byname() returns NULL,
we need check the return value.
Fixes:
858e26a515c2
("spi: spi-fsl-qspi: Reduce devm_ioremap size to 4 times AHB buffer size")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link:
https://lore.kernel.org/r/20220505093954.1285615-1-yangyingliang@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-qspi.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/spi/spi-fsl-qspi.c
b/drivers/spi/spi-fsl-qspi.c
index 9851551ebbe05d9381d3344469df10242f52b4dd..46ae46a944c5ce89818ddef2f2a622a96ee95036 100644
(file)
--- a/
drivers/spi/spi-fsl-qspi.c
+++ b/
drivers/spi/spi-fsl-qspi.c
@@
-876,6
+876,10
@@
static int fsl_qspi_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"QuadSPI-memory");
+ if (!res) {
+ ret = -EINVAL;
+ goto err_put_ctrl;
+ }
q->memmap_phy = res->start;
/* Since there are 4 cs, map size required is 4 times ahb_buf_size */
q->ahb_addr = devm_ioremap(dev, q->memmap_phy,