futex: Initialize futex_phash_new during fork().
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Mon, 23 Jun 2025 08:34:08 +0000 (10:34 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 23 Jun 2025 12:50:37 +0000 (14:50 +0200)
During a hash resize operation the new private hash is stored in
mm_struct::futex_phash_new if the current hash can not be immediately
replaced.

The new hash must not be copied during fork() into the new task. Doing
so will lead to a double-free of the memory by the two tasks.

Initialize the mm_struct::futex_phash_new during fork().

Closes: https://lore.kernel.org/all/aFBQ8CBKmRzEqIfS@mozart.vkv.me/
Fixes: bd54df5ea7cad ("futex: Allow to resize the private local hash")
Reported-by: Calvin Owens <calvin@wbinvd.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Calvin Owens <calvin@wbinvd.org>
Link: https://lkml.kernel.org/r/20250623083408.jTiJiC6_@linutronix.de
include/linux/futex.h

index 005b040c4791bb12feae66476dbee66dc8b8df07..b37193653e6b5d7d562ac08f93d4ee41eb8e72a2 100644 (file)
@@ -89,6 +89,7 @@ void futex_hash_free(struct mm_struct *mm);
 static inline void futex_mm_init(struct mm_struct *mm)
 {
        RCU_INIT_POINTER(mm->futex_phash, NULL);
+       mm->futex_phash_new = NULL;
        mutex_init(&mm->futex_hash_lock);
 }