ALSA: seq: Don't clear bank selection at event -> UMP MIDI2 conversion
authorTakashi Iwai <tiwai@suse.de>
Mon, 27 May 2024 15:18:50 +0000 (17:18 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 28 May 2024 11:07:20 +0000 (13:07 +0200)
The current code to convert from a legacy sequencer event to UMP MIDI2
clears the bank selection at each time the program change is
submitted.  This is confusing and may lead to incorrect bank values
tranmitted to the destination in the end.

Drop the line to clear the bank info and keep the provided values.

Fixes: e9e02819a98a ("ALSA: seq: Automatic conversion of UMP events")
Link: https://lore.kernel.org/r/20240527151852.29036-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_ump_convert.c

index c21be87f5da9e8c83125ddee7cd2232ca5fbd2b4..f5d22dd008426ffa087277377590a0db6bef0c4c 100644 (file)
@@ -892,7 +892,6 @@ static int pgm_ev_to_ump_midi2(const struct snd_seq_event *event,
                data->pg.bank_msb = cc->cc_bank_msb;
                data->pg.bank_lsb = cc->cc_bank_lsb;
                cc->bank_set = 0;
-               cc->cc_bank_msb = cc->cc_bank_lsb = 0;
        }
        return 1;
 }