pds_core: add an error code check in pdsc_dl_info_get

check the value of 'ret' after call 'devlink_info_version_stored_put'.

Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
Link: https://lore.kernel.org/r/20231019083351.1526484-1-suhui@nfschina.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c
index 8b2b9e0d59f31b1b915a7eed1475fdaf1dcb9147..57f88c8b37defe17fed6e8b9d82578a4f9701dc2 100644 (file)
--- a/drivers/net/ethernet/amd/pds_core/devlink.c
+++ b/drivers/net/ethernet/amd/pds_core/devlink.c
@@ -124,6 +124,8 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
                        snprintf(buf, sizeof(buf), "fw.slot_%d", i);
                err = devlink_info_version_stored_put(req, buf,
                                                      fw_list.fw_names[i].fw_version);
+               if (err)
+                       return err;
        }
 
        err = devlink_info_version_running_put(req,