projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
16c6cac
)
spi: sg2044-nor: fix uninitialized variable in probe
author
Dan Carpenter
<dan.carpenter@linaro.org>
Fri, 14 Mar 2025 10:10:26 +0000
(13:10 +0300)
committer
Mark Brown
<broonie@kernel.org>
Sun, 16 Mar 2025 23:34:17 +0000
(23:34 +0000)
The "base" pointer is uninitialized. It should be "spifmc->io_base"
instead.
Fixes:
de16c322eefb
("spi: sophgo: add SG2044 SPI NOR controller driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Link:
https://patch.msgid.link/d343921b-16b8-429b-888a-f51bb6f2edc8@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-sg2044-nor.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/spi/spi-sg2044-nor.c
b/drivers/spi/spi-sg2044-nor.c
index baa4cf67766312fddf203d527f2b3821a38eb9e8..97d6b3a21d545f0287d650c1bfa8bf38a2ea09b0 100644
(file)
--- a/
drivers/spi/spi-sg2044-nor.c
+++ b/
drivers/spi/spi-sg2044-nor.c
@@
-427,7
+427,6
@@
static int sg2044_spifmc_probe(struct platform_device *pdev)
{
struct spi_controller *ctrl;
struct sg2044_spifmc *spifmc;
- void __iomem *base;
int ret;
ctrl = devm_spi_alloc_host(&pdev->dev, sizeof(*spifmc));
@@
-447,8
+446,8
@@
static int sg2044_spifmc_probe(struct platform_device *pdev)
spifmc->ctrl = ctrl;
spifmc->io_base = devm_platform_ioremap_resource(pdev, 0);
- if (IS_ERR(base))
- return PTR_ERR(base);
+ if (IS_ERR(
spifmc->io_
base))
+ return PTR_ERR(
spifmc->io_
base);
ctrl->num_chipselect = 1;
ctrl->dev.of_node = pdev->dev.of_node;