[media] pxa_camera: Fix incorrect test in the image size generation
authorPetr Cvek <petr.cvek@tul.cz>
Mon, 1 May 2017 04:21:10 +0000 (01:21 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Jun 2017 10:39:48 +0000 (07:39 -0300)
During the transfer from the soc_camera a test in pxa_mbus_image_size()
got removed. Without it any PXA_MBUS_LAYOUT_PACKED format causes either
the return of a wrong value (PXA_MBUS_PACKING_2X8_PADHI doubles
the correct value) or EINVAL (PXA_MBUS_PACKING_NONE and
PXA_MBUS_PACKING_EXTEND16). This was observed in an error from the ffmpeg
(for some of the YUYV subvariants).

This patch re-adds the same test as in soc_camera version.

Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/pxa_camera.c

index eb9e9d5a101f4a986caf12c1c1272bdcb9e93ef6..a572fc9b7a73f558b3e2b1549b040abd47056ab6 100644 (file)
@@ -575,6 +575,9 @@ static s32 pxa_mbus_bytes_per_line(u32 width, const struct pxa_mbus_pixelfmt *mf
 static s32 pxa_mbus_image_size(const struct pxa_mbus_pixelfmt *mf,
                        u32 bytes_per_line, u32 height)
 {
+       if (mf->layout == PXA_MBUS_LAYOUT_PACKED)
+               return bytes_per_line * height;
+
        switch (mf->packing) {
        case PXA_MBUS_PACKING_2X8_PADHI:
                return bytes_per_line * height * 2;