iio: adc: bcm_iproc_adc: make use of regmap_clear_bits()
authorTrevor Gamblin <tgamblin@baylibre.com>
Mon, 17 Jun 2024 13:49:47 +0000 (09:49 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 25 Jun 2024 20:04:44 +0000 (21:04 +0100)
Instead of using regmap_update_bits() and passing val = 0, use
regmap_clear_bits().

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-7-88d1338c4cca@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/bcm_iproc_adc.c

index 5bc514bd5ebc3d0e4df3110291814a49d22b6535..6bc149c5141413cb969a1ae7ba53d99f83a0d393 100644 (file)
@@ -357,8 +357,8 @@ static int iproc_adc_enable(struct iio_dev *indio_dev)
        int ret;
 
        /* Set i_amux = 3b'000, select channel 0 */
-       ret = regmap_update_bits(adc_priv->regmap, IPROC_ANALOG_CONTROL,
-                               IPROC_ADC_CHANNEL_SEL_MASK, 0);
+       ret = regmap_clear_bits(adc_priv->regmap, IPROC_ANALOG_CONTROL,
+                               IPROC_ADC_CHANNEL_SEL_MASK);
        if (ret) {
                dev_err(&indio_dev->dev,
                        "failed to write IPROC_ANALOG_CONTROL %d\n", ret);
@@ -543,8 +543,8 @@ static int iproc_adc_probe(struct platform_device *pdev)
        if (adc_priv->irqno < 0)
                return adc_priv->irqno;
 
-       ret = regmap_update_bits(adc_priv->regmap, IPROC_REGCTL2,
-                               IPROC_ADC_AUXIN_SCAN_ENA, 0);
+       ret = regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2,
+                               IPROC_ADC_AUXIN_SCAN_ENA);
        if (ret) {
                dev_err(&pdev->dev, "failed to write IPROC_REGCTL2 %d\n", ret);
                return ret;