staging: vc04_services: Delete unnecessary NULL check
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 24 Apr 2024 11:43:28 +0000 (14:43 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 May 2024 16:41:48 +0000 (18:41 +0200)
The "state" pointer points to an offset in the middle of the "mgmt"
struct so it can't possibly be NULL.  And also we dereferenced it on the
line before.  So this NULL check is pointless.  Delete it.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/526ec2ff-6277-4d5d-b2d9-63b087a97c7c@moroto.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c

index 9fe35864936c4d293c65ff3b44686ebce5ce433c..3c63347d2d08744ca0aa12649aadc40935201dd6 100644 (file)
@@ -1170,11 +1170,6 @@ static int vchiq_open(struct inode *inode, struct file *file)
 
        dev_dbg(state->dev, "arm: vchiq open\n");
 
-       if (!state) {
-               dev_err(state->dev, "arm: vchiq has no connection to VideoCore\n");
-               return -ENOTCONN;
-       }
-
        instance = kzalloc(sizeof(*instance), GFP_KERNEL);
        if (!instance)
                return -ENOMEM;