bpf: Add __rcu_read_{lock,unlock} into btf id deny list
authorYafang Shao <laoar.shao@gmail.com>
Mon, 24 Apr 2023 16:11:03 +0000 (16:11 +0000)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 24 Apr 2023 21:16:01 +0000 (14:16 -0700)
The tracing recursion prevention mechanism must be protected by rcu, that
leaves __rcu_read_{lock,unlock} unprotected by this mechanism. If we trace
them, the recursion will happen. Let's add them into the btf id deny list.

When CONFIG_PREEMPT_RCU is enabled, it can be reproduced with a simple bpf
program as such:
  SEC("fentry/__rcu_read_lock")
  int fentry_run()
  {
      return 0;
  }

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Link: https://lore.kernel.org/r/20230424161104.3737-2-laoar.shao@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/verifier.c

index 5c4aa393f65a6451d6752041ce9db8f1459b5cb2..fbcf5a4e2fcd49cc8a8242e447929a35fbc54ca4 100644 (file)
@@ -18671,6 +18671,10 @@ BTF_ID(func, rcu_read_unlock_strict)
 BTF_ID(func, preempt_count_add)
 BTF_ID(func, preempt_count_sub)
 #endif
+#ifdef CONFIG_PREEMPT_RCU
+BTF_ID(func, __rcu_read_lock)
+BTF_ID(func, __rcu_read_unlock)
+#endif
 BTF_SET_END(btf_id_deny)
 
 static bool can_be_sleepable(struct bpf_prog *prog)