kunit: Fix NULL-dereference in kunit_init_suite() if suite->log is NULL
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Mon, 18 Dec 2023 15:17:29 +0000 (15:17 +0000)
committerShuah Khan <skhan@linuxfoundation.org>
Wed, 3 Jan 2024 16:06:19 +0000 (09:06 -0700)
suite->log must be checked for NULL before passing it to
string_stream_clear(). This was done in kunit_init_test() but was missing
from kunit_init_suite().

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 6d696c4695c5 ("kunit: add ability to run tests after boot using debugfs")
Reviewed-by: Rae Moar <rmoar@google.com>
Acked-by: David Gow <davidgow@google.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
lib/kunit/test.c

index 3a3d4ebb35dbeb237d081c04f8f18a392623ea28..f95d2093a0aa3359c0cb08462ea62e76ab0f2ecf 100644 (file)
@@ -697,7 +697,9 @@ static void kunit_init_suite(struct kunit_suite *suite)
        kunit_debugfs_create_suite(suite);
        suite->status_comment[0] = '\0';
        suite->suite_init_err = 0;
-       string_stream_clear(suite->log);
+
+       if (suite->log)
+               string_stream_clear(suite->log);
 }
 
 bool kunit_enabled(void)