iommufd: Fix uninitialized rc in iommufd_access_rw()
authorNicolin Chen <nicolinc@nvidia.com>
Thu, 27 Feb 2025 20:07:29 +0000 (12:07 -0800)
committerJason Gunthorpe <jgg@nvidia.com>
Tue, 4 Mar 2025 13:41:25 +0000 (09:41 -0400)
Reported by smatch:
drivers/iommu/iommufd/device.c:1392 iommufd_access_rw() error: uninitialized symbol 'rc'.

Fixes: 8d40205f6093 ("iommufd: Add kAPI toward external drivers for kernel access")
Link: https://patch.msgid.link/r/20250227200729.85030-1-nicolinc@nvidia.com
Cc: stable@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202502271339.a2nWr9UA-lkp@intel.com/
[nicolinc: can't find an original report but only in "old smatch warnings"]
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/iommu/iommufd/device.c

index 4e107f69f951a26cb463ce3f9691f808112371bd..b2f0cb909e6dfa38015de3dd57a3c3e0bda611e8 100644 (file)
@@ -1349,7 +1349,7 @@ int iommufd_access_rw(struct iommufd_access *access, unsigned long iova,
        struct io_pagetable *iopt;
        struct iopt_area *area;
        unsigned long last_iova;
-       int rc;
+       int rc = -EINVAL;
 
        if (!length)
                return -EINVAL;