ASoC: SOF: topology: Use krealloc_array() to replace krealloc()
authorZhang Heng <zhangheng@kylinos.cn>
Fri, 17 Jan 2025 01:43:43 +0000 (09:43 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 3 Feb 2025 14:03:45 +0000 (14:03 +0000)
Use krealloc_array() to replace krealloc() with multiplication.
krealloc_array() has multiply overflow check, which will be safer.

Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
Link: https://patch.msgid.link/20250117014343.451503-1-zhangheng@kylinos.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/topology.c

index 688cc7ac17148a85adacfbb71e092f71c94134fa..dc9cb8324067831846b865f75e2f530c57e59062 100644 (file)
@@ -1273,8 +1273,8 @@ static int sof_widget_parse_tokens(struct snd_soc_component *scomp, struct snd_s
                        struct snd_sof_tuple *new_tuples;
 
                        num_tuples += token_list[object_token_list[i]].count * (num_sets - 1);
-                       new_tuples = krealloc(swidget->tuples,
-                                             sizeof(*new_tuples) * num_tuples, GFP_KERNEL);
+                       new_tuples = krealloc_array(swidget->tuples,
+                                                   num_tuples, sizeof(*new_tuples), GFP_KERNEL);
                        if (!new_tuples) {
                                ret = -ENOMEM;
                                goto err;