mailbox: mtk-cmdq: Refine GCE_GCTL_VALUE setting

Add cmdq_gctl_value_toggle() to configure GCE_CTRL_BY_SW and GCE_DDR_EN
together in the same GCE_GCTL_VALUE register.

For the SoCs whose GCE is located in MMINFRA and uses MMINFRA_AO power,
this allows it to be written without enabling the clocks. Otherwise, all
GCE registers should be written after the GCE clocks are enabled.
Move this function into cmdq_runtime_resume() and cmdq_runtime_suspend()
to ensure it is called when the GCE clock is enabled.

Fixes: 7abd037aa581 ("mailbox: mtk-cmdq: add gce ddr enable support flow")
Signed-off-by: Jason-JH Lin <jason-jh.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index d186865b8dce64b5f719cd0f0a772ee822fd236f..ab4e8d1954a16ecbef87ea9c0ad2dc1e54c0c5c1 100644 (file)
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -92,18 +92,6 @@ struct gce_plat {
        u32 gce_num;
 };
 
-static void cmdq_sw_ddr_enable(struct cmdq *cmdq, bool enable)
-{
-       WARN_ON(clk_bulk_enable(cmdq->pdata->gce_num, cmdq->clocks));
-
-       if (enable)
-               writel(GCE_DDR_EN | GCE_CTRL_BY_SW, cmdq->base + GCE_GCTL_VALUE);
-       else
-               writel(GCE_CTRL_BY_SW, cmdq->base + GCE_GCTL_VALUE);
-
-       clk_bulk_disable(cmdq->pdata->gce_num, cmdq->clocks);
-}
-
 u8 cmdq_get_shift_pa(struct mbox_chan *chan)
 {
        struct cmdq *cmdq = container_of(chan->mbox, struct cmdq, mbox);
@@ -112,6 +100,19 @@ u8 cmdq_get_shift_pa(struct mbox_chan *chan)
 }
 EXPORT_SYMBOL(cmdq_get_shift_pa);
 
+static void cmdq_gctl_value_toggle(struct cmdq *cmdq, bool ddr_enable)
+{
+       u32 val = cmdq->pdata->control_by_sw ? GCE_CTRL_BY_SW : 0;
+
+       if (!cmdq->pdata->control_by_sw && !cmdq->pdata->sw_ddr_en)
+               return;
+
+       if (cmdq->pdata->sw_ddr_en && ddr_enable)
+               val |= GCE_DDR_EN;
+
+       writel(val, cmdq->base + GCE_GCTL_VALUE);
+}
+
 static int cmdq_thread_suspend(struct cmdq *cmdq, struct cmdq_thread *thread)
 {
        u32 status;
@@ -140,16 +141,10 @@ static void cmdq_thread_resume(struct cmdq_thread *thread)
 static void cmdq_init(struct cmdq *cmdq)
 {
        int i;
-       u32 gctl_regval = 0;
 
        WARN_ON(clk_bulk_enable(cmdq->pdata->gce_num, cmdq->clocks));
-       if (cmdq->pdata->control_by_sw)
-               gctl_regval = GCE_CTRL_BY_SW;
-       if (cmdq->pdata->sw_ddr_en)
-               gctl_regval |= GCE_DDR_EN;
 
-       if (gctl_regval)
-               writel(gctl_regval, cmdq->base + GCE_GCTL_VALUE);
+       cmdq_gctl_value_toggle(cmdq, true);
 
        writel(CMDQ_THR_ACTIVE_SLOT_CYCLES, cmdq->base + CMDQ_THR_SLOT_CYCLES);
        for (i = 0; i <= CMDQ_MAX_EVENT; i++)
@@ -315,14 +310,21 @@ static irqreturn_t cmdq_irq_handler(int irq, void *dev)
 static int cmdq_runtime_resume(struct device *dev)
 {
        struct cmdq *cmdq = dev_get_drvdata(dev);
+       int ret;
 
-       return clk_bulk_enable(cmdq->pdata->gce_num, cmdq->clocks);
+       ret = clk_bulk_enable(cmdq->pdata->gce_num, cmdq->clocks);
+       if (ret)
+               return ret;
+
+       cmdq_gctl_value_toggle(cmdq, true);
+       return 0;
 }
 
 static int cmdq_runtime_suspend(struct device *dev)
 {
        struct cmdq *cmdq = dev_get_drvdata(dev);
 
+       cmdq_gctl_value_toggle(cmdq, false);
        clk_bulk_disable(cmdq->pdata->gce_num, cmdq->clocks);
        return 0;
 }
@@ -347,9 +349,6 @@ static int cmdq_suspend(struct device *dev)
        if (task_running)
                dev_warn(dev, "exist running task(s) in suspend\n");
 
-       if (cmdq->pdata->sw_ddr_en)
-               cmdq_sw_ddr_enable(cmdq, false);
-
        return pm_runtime_force_suspend(dev);
 }
 
@@ -360,9 +359,6 @@ static int cmdq_resume(struct device *dev)
        WARN_ON(pm_runtime_force_resume(dev));
        cmdq->suspended = false;
 
-       if (cmdq->pdata->sw_ddr_en)
-               cmdq_sw_ddr_enable(cmdq, true);
-
        return 0;
 }
 
@@ -370,9 +366,6 @@ static void cmdq_remove(struct platform_device *pdev)
 {
        struct cmdq *cmdq = platform_get_drvdata(pdev);
 
-       if (cmdq->pdata->sw_ddr_en)
-               cmdq_sw_ddr_enable(cmdq, false);
-
        if (!IS_ENABLED(CONFIG_PM))
                cmdq_runtime_suspend(&pdev->dev);