net: ibm: emac: rgmii: devm_platform_get_resource

Simplifies the probe function by a bit and allows removing the _remove
function such that devm now handles all cleanup.

printk gets converted to dev_err as np is now gone.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://patch.msgid.link/20241030203727.6039-7-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/ibm/emac/rgmii.c b/drivers/net/ethernet/ibm/emac/rgmii.c
index 9063f0a17e250d7c51e3f8a591a4e2d729c76543..b544dd8633b7b71852368c0cf634c655968592cd 100644 (file)
--- a/drivers/net/ethernet/ibm/emac/rgmii.c
+++ b/drivers/net/ethernet/ibm/emac/rgmii.c
@@ -216,9 +216,7 @@ void *rgmii_dump_regs(struct platform_device *ofdev, void *buf)
 
 static int rgmii_probe(struct platform_device *ofdev)
 {
-       struct device_node *np = ofdev->dev.of_node;
        struct rgmii_instance *dev;
-       struct resource regs;
        int err;
 
        dev = devm_kzalloc(&ofdev->dev, sizeof(struct rgmii_instance),
@@ -232,16 +230,10 @@ static int rgmii_probe(struct platform_device *ofdev)
 
        dev->ofdev = ofdev;
 
-       if (of_address_to_resource(np, 0, &regs)) {
-               printk(KERN_ERR "%pOF: Can't get registers address\n", np);
-               return -ENXIO;
-       }
-
-       dev->base = (struct rgmii_regs __iomem *)ioremap(regs.start,
-                                                sizeof(struct rgmii_regs));
-       if (dev->base == NULL) {
-               printk(KERN_ERR "%pOF: Can't map device registers!\n", np);
-               return -ENOMEM;
+       dev->base = devm_platform_ioremap_resource(ofdev, 0);
+       if (IS_ERR(dev->base)) {
+               dev_err(&ofdev->dev, "can't map device registers");
+               return PTR_ERR(dev->base);
        }
 
        /* Check for RGMII flags */
@@ -269,15 +261,6 @@ static int rgmii_probe(struct platform_device *ofdev)
        return 0;
 }
 
-static void rgmii_remove(struct platform_device *ofdev)
-{
-       struct rgmii_instance *dev = platform_get_drvdata(ofdev);
-
-       WARN_ON(dev->users != 0);
-
-       iounmap(dev->base);
-}
-
 static const struct of_device_id rgmii_match[] =
 {
        {
@@ -295,7 +278,6 @@ static struct platform_driver rgmii_driver = {
                .of_match_table = rgmii_match,
        },
        .probe = rgmii_probe,
-       .remove = rgmii_remove,
 };
 
 int __init rgmii_init(void)